Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: content/browser/accessibility/browser_accessibility_mac.mm

Issue 1762143002: Use unique IDs for accessibility nodes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix null obj deref in DCHECK Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_mac.mm
diff --git a/content/browser/accessibility/browser_accessibility_mac.mm b/content/browser/accessibility/browser_accessibility_mac.mm
index da1f55e9673df1b9b13bfbf7f218a6edf0c0c6f7..34475bdc3092e0136bc9ba4de001ed79b7cee421 100644
--- a/content/browser/accessibility/browser_accessibility_mac.mm
+++ b/content/browser/accessibility/browser_accessibility_mac.mm
@@ -64,13 +64,17 @@ void BrowserAccessibilityMac::RecreateNativeObject() {
}
const BrowserAccessibilityCocoa*
-BrowserAccessibility::ToBrowserAccessibilityCocoa() const {
- return static_cast<const BrowserAccessibilityMac*>(this)->native_view();
+ToBrowserAccessibilityCocoa(const BrowserAccessibility* obj) {
+ DCHECK(obj);
+ DCHECK(obj->IsNative());
+ return static_cast<const BrowserAccessibilityMac*>(obj)->native_view();
}
-BrowserAccessibilityCocoa* BrowserAccessibility::ToBrowserAccessibilityCocoa() {
- return static_cast<BrowserAccessibilityMac*>(this)->
- native_view();
+BrowserAccessibilityCocoa* ToBrowserAccessibilityCocoa(
+ BrowserAccessibility* obj) {
+ DCHECK(obj);
+ DCHECK(obj->IsNative());
+ return static_cast<BrowserAccessibilityMac*>(obj)->native_view();
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698