content/browser/accessibility/accessibility_tree_formatter_auralinux.cc - Issue 1762143002: Use unique IDs for accessibility nodes on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_auralinux.cc

Issue 1762143002: Use unique IDs for accessibility nodes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix null obj deref in DCHECK Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/accessibility_event_recorder_win.cc ('k') | content/browser/accessibility/accessibility_tree_formatter_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/accessibility_tree_formatter_auralinux.cc

diff --git a/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc b/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc

index 4ebb1c0e46de205ee30e31816f9fb1114d70807c..ef954c9e26ca037809134b69e323fec5854c4723 100644

--- a/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc

+++ b/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc

@@ -46,8 +46,7 @@ void AccessibilityTreeFormatterAuraLinux::AddProperties(

base::DictionaryValue* dict) {

dict->SetInteger("id", node.GetId());

BrowserAccessibilityAuraLinux* acc_obj =

- const_cast<BrowserAccessibility*>(&node)

- ->ToBrowserAccessibilityAuraLinux();

+ ToBrowserAccessibilityAuraLinux(const_cast<BrowserAccessibility*>(&node));

AtkObject* atk_object = acc_obj->GetAtkObject();

AtkRole role = acc_obj->atk_role();