content/browser/accessibility/accessibility_event_recorder_win.cc - Issue 1762143002: Use unique IDs for accessibility nodes on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_event_recorder_win.cc

Issue 1762143002: Use unique IDs for accessibility nodes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix null obj deref in DCHECK Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/accessibility_event_recorder_win.cc

diff --git a/content/browser/accessibility/accessibility_event_recorder_win.cc b/content/browser/accessibility/accessibility_event_recorder_win.cc

index fa767494fb4d2eee3fa0729fb40d29147ef901db..cb40bfbb85070db48aed7c96d196b1e77ad02b84 100644

--- a/content/browser/accessibility/accessibility_event_recorder_win.cc

+++ b/content/browser/accessibility/accessibility_event_recorder_win.cc

@@ -287,7 +287,7 @@ HRESULT AccessibilityEventRecorderWin::AccessibleObjectFromWindowWrapper(

if (accessibility_hwnd != hwnd)

return E_FAIL;

- IAccessible* obj = manager_->GetRoot()->ToBrowserAccessibilityWin();

+ IAccessible* obj = ToBrowserAccessibilityWin(manager_->GetRoot());

obj->AddRef();

*ppv_object = obj;

return S_OK;

« no previous file with comments | « no previous file | content/browser/accessibility/accessibility_tree_formatter_auralinux.cc » ('j') | no next file with comments »