Issue 1762073002: Hand edited changes to dart:html to correct code size regressions.

Issue 1762073002: Hand edited changes to dart:html to correct code size regressions. (Closed)

Created:
4 years, 9 months ago by Jacob

Modified:
4 years, 9 months ago

Reviewers:
Alan Knight, terry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Hand edited changes to dart:html to correct code size regressions. BUG= Committed: https://github.com/dart-lang/sdk/commit/4aa00a94db8a5c5979ef8580f80611f48931b390

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	sdk/lib/html/dart2js/html_dart2js.dart	View		6 chunks	+10 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

Jacob

These are ugly hacks. We should fix the code generation scripts and evaluate what the ...

4 years, 9 months ago (2016-03-03 21:45:08 UTC) #2

Jacob

On 2016/03/03 21:45:08, Jacob wrote: > These are ugly hacks. We should fix the code ...

4 years, 9 months ago (2016-03-03 21:45:33 UTC) #3

Jacob

On 2016/03/03 21:45:08, Jacob wrote: > These are ugly hacks. We should fix the code ...

4 years, 9 months ago (2016-03-03 21:45:34 UTC) #4

Jacob

Committed patchset #1 (id:1) manually as 4aa00a94db8a5c5979ef8580f80611f48931b390 (presubmit successful).

4 years, 9 months ago (2016-03-03 21:45:44 UTC) #6

Alan Knight

4 years, 9 months ago (2016-03-03 21:50:02 UTC) #7

Message was sent while issue was closed.

The VTTCue ones should probably be num|String, because they can be either a
number or the string "auto".