Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 1762073002: Hand edited changes to dart:html to correct code size regressions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 744e7338c7d9e744274db8c5f0ba38ed74b11c9e..2464e3b14703bde3b166ed9e51ad68d97f568282 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -394,6 +394,7 @@ class AnimationEffectTiming extends Interceptor {
@DomName('AnimationEffectTiming.duration')
@DocsEditable()
@Experimental() // untriaged
+ @Creates('Null')
Object duration;
@DomName('AnimationEffectTiming.easing')
@@ -3763,6 +3764,7 @@ class CryptoKey extends Interceptor {
@DomName('CryptoKey.algorithm')
@DocsEditable()
@Experimental() // untriaged
+ @Creates('Null')
final Object algorithm;
@DomName('CryptoKey.extractable')
@@ -4178,6 +4180,7 @@ class CssStyleDeclaration extends Interceptor with
@DomName('CSSStyleDeclaration.__getter__')
@DocsEditable()
@Experimental() // untriaged
+ @Creates('Null')
Object __getter__(String name) native;
@DomName('CSSStyleDeclaration.__setter__')
@@ -29912,6 +29915,8 @@ class ServiceWorkerMessageEvent extends Event {
@DomName('ServiceWorkerMessageEvent.data')
@DocsEditable()
@Experimental() // untriaged
+ // TODO(jacobr): we need to actually convert to a SerializedScriptValue
+ @Creates('=Object')
final Object data;
@DomName('ServiceWorkerMessageEvent.lastEventId')
@@ -29932,6 +29937,9 @@ class ServiceWorkerMessageEvent extends Event {
@DomName('ServiceWorkerMessageEvent.source')
@DocsEditable()
@Experimental() // untriaged
+ // TODO(jacobr): this isn't quite right.
+ @Creates('Null')
+ @Returns('EventTarget|=Object')
final Object source;
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -34139,12 +34147,12 @@ class VttCue extends TextTrackCue {
@DomName('VTTCue.line')
@DocsEditable()
@Experimental() // untriaged
- Object line;
+ num line;
@DomName('VTTCue.position')
@DocsEditable()
@Experimental() // untriaged
- Object position;
+ num position;
@DomName('VTTCue.regionId')
@DocsEditable()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698