Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated

Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated

This CL relies on https://codereview.chromium.org/1757983002/ (Add SkSpecialImage-based methods to SkImageFilter)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1762013002

TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/4418dbac3386f26c8da62ab242be9c178961eb18

[robertphillips, 2016-03-03 20:40:51]

Description was changed from

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated
==========

to

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-04 13:40:06]

Description was changed from

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-04 13:40:07]

robertphillips@google.com changed reviewers:
+ senorblanco@chromium.org, senorblanco@google.com

[robertphillips, 2016-03-04 13:40:54]

Description was changed from

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated

This CL relies on https://codereview.chromium.org/1757983002/ (Add
SkSpecialImage-based methods to SkImageFilter)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-03-04 15:55:05]

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkDevice.cpp#n...
src/core/SkDevice.cpp:424:
SkAutoTUnref<SkSpecialImage>resultImg(filter->filterImage(srcImg, ctx,
&offset));
Nit: need space between > and resultImg.

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkSpecialImage.h
File src/core/SkSpecialImage.h (right):

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkSpecialImage...
src/core/SkSpecialImage.h:75: // TODO: hide this when GrLayerHoister uses
SkSpecialImages more fully
Log a bug and reference it here?

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkSpecialImage...
src/core/SkSpecialImage.h:108: bool getROPixels(SkBitmap*) const;
getROPixelsForTesting(), then?

[robertphillips, 2016-03-04 18:08:36]

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkDevice.cpp#n...
src/core/SkDevice.cpp:424:
SkAutoTUnref<SkSpecialImage>resultImg(filter->filterImage(srcImg, ctx,
&offset));
On 2016/03/04 15:55:05, Stephen White wrote:
> Nit: need space between > and resultImg.

Done.

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkSpecialImage.h
File src/core/SkSpecialImage.h (right):

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkSpecialImage...
src/core/SkSpecialImage.h:75: // TODO: hide this when GrLayerHoister uses
SkSpecialImages more fully
On 2016/03/04 15:55:05, Stephen White wrote:
> Log a bug and reference it here?

Done.

https://codereview.chromium.org/1762013002/diff/40001/src/core/SkSpecialImage...
src/core/SkSpecialImage.h:108: bool getROPixels(SkBitmap*) const;
On 2016/03/04 15:55:05, Stephen White wrote:
> getROPixelsForTesting(), then?

Done - went with a prefix.

[Stephen White, 2016-03-04 22:52:55]

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkCanvas.cpp#...
src/core/SkCanvas.cpp:1415: // TODO: add drawSprite(SkSpecialImage) to SkDevice?
Nit: I'd either log this as a bug and reference it, or remove the TODO if
we're not certain that we're going to do it.

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkDevice.cpp#...
src/core/SkDevice.cpp:430: // TODO: add drawSprite(SkSpecialImage) to SkDevice?
Nit: log a bug and reference it, or just remove the TODO.

https://codereview.chromium.org/1762013002/diff/100001/tests/ImageFilterTest.cpp
File tests/ImageFilterTest.cpp (right):

https://codereview.chromium.org/1762013002/diff/100001/tests/ImageFilterTest....
tests/ImageFilterTest.cpp:1291: run_raster_test(reporter, 100,
test_composed_imagefilter_offset);
It looks like the widthHeight param is always the same for the raster & GPU
flavours of a test. Could you remove the param from run_*_test() and bake it
into the test instead?

https://codereview.chromium.org/1762013002/diff/100001/tests/ImageFilterTest....
tests/ImageFilterTest.cpp:1295:
DEF_GPUTEST_FOR_NATIVE_CONTEXT(ComposedImageFilterOffset_Gpu, reporter, context)
{
Some of these tests probably don't need to be run in both raster and GPU modes,
since the filter code is "generic". But I suppose there's no harm in it.

[robertphillips, 2016-03-07 17:35:57]

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkCanvas.cpp#...
src/core/SkCanvas.cpp:1415: // TODO: add drawSprite(SkSpecialImage) to SkDevice?
On 2016/03/04 22:52:55, Stephen White wrote:
> Nit: I'd either log this as a bug and reference it, or remove the TODO if
> we're not certain that we're going to do it.

Done.

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/1762013002/diff/100001/src/core/SkDevice.cpp#...
src/core/SkDevice.cpp:430: // TODO: add drawSprite(SkSpecialImage) to SkDevice?
On 2016/03/04 22:52:55, Stephen White wrote:
> Nit: log a bug and reference it, or just remove the TODO.

Done.

https://codereview.chromium.org/1762013002/diff/100001/tests/ImageFilterTest.cpp
File tests/ImageFilterTest.cpp (right):

https://codereview.chromium.org/1762013002/diff/100001/tests/ImageFilterTest....
tests/ImageFilterTest.cpp:1291: run_raster_test(reporter, 100,
test_composed_imagefilter_offset);
Unfortunately, the ImageFilterClippedPictureImageFilter* tests use a different
value.

https://codereview.chromium.org/1762013002/diff/100001/tests/ImageFilterTest....
tests/ImageFilterTest.cpp:1295:
DEF_GPUTEST_FOR_NATIVE_CONTEXT(ComposedImageFilterOffset_Gpu, reporter, context)
{
On 2016/03/04 22:52:55, Stephen White wrote:
> Some of these tests probably don't need to be run in both raster and GPU
modes,
> since the filter code is "generic". But I suppose there's no harm in it.

Right - hopefully they will all become generic but I would still like to test
both back ends.

[Stephen White, 2016-03-07 18:45:36]

LGTM

[robertphillips, 2016-03-07 18:48:36]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 18:48:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762013002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762013002/120001

[commit-bot: I haz the power, 2016-03-07 18:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 18:51:25]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-03-07 19:47:34]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 19:47:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762013002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762013002/140001

[commit-bot: I haz the power, 2016-03-07 20:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 20:12:17]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-07 20:19:46]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-03-07 20:19:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1762013002/#ps140001
(title: "Fix no-GPU build")

[commit-bot: I haz the power, 2016-03-07 20:19:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762013002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762013002/140001

[commit-bot: I haz the power, 2016-03-07 20:22:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 20:22:09]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-03-07 20:43:59]

Description was changed from

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated

This CL relies on https://codereview.chromium.org/1757983002/ (Add
SkSpecialImage-based methods to SkImageFilter)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated

This CL relies on https://codereview.chromium.org/1757983002/ (Add
SkSpecialImage-based methods to SkImageFilter)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com
==========

[robertphillips, 2016-03-07 20:43:59]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-03-07 20:44:06]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-03-07 20:44:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762013002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762013002/140001

[commit-bot: I haz the power, 2016-03-07 20:45:17]

Description was changed from

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated

This CL relies on https://codereview.chromium.org/1757983002/ (Add
SkSpecialImage-based methods to SkImageFilter)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com
==========

to

==========
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated

This CL relies on https://codereview.chromium.org/1757983002/ (Add
SkSpecialImage-based methods to SkImageFilter)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/4418dbac3386f26c8da62ab242be9c178961eb18
==========

[commit-bot: I haz the power, 2016-03-07 20:45:18]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/4418dbac3386f26c8da62ab242be9c178961eb18