Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: include/core/SkImageFilter.h

Issue 1762013002: Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated (Closed) Base URL: https://skia.googlesource.com/skia.git@if-fragment
Patch Set: Fix no-GPU build Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkCanvas.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkImageFilter.h
diff --git a/include/core/SkImageFilter.h b/include/core/SkImageFilter.h
index 162d5030716bc0e3860b5ee92bd1d89650c7eb24..93f3e3cc0bc6286d4b3b016aafaa586a83518c06 100644
--- a/include/core/SkImageFilter.h
+++ b/include/core/SkImageFilter.h
@@ -137,20 +137,19 @@ public:
/**
* Request a new (result) image to be created from the src image.
- * If the src has no pixels (isNull()) then the request just wants to
- * receive the config and width/height of the result.
*
- * The matrix is the current matrix on the canvas.
+ * The context contains the environment in which the filter is occurring.
+ * It includes the clip bounds, CTM and cache.
*
* Offset is the amount to translate the resulting image relative to the
* src when it is drawn. This is an out-param.
*
- * If the result image cannot be created, return false, in which case both
- * the result and offset parameters will be ignored by the caller.
+ * If the result image cannot be created, return null, in which case
+ * the offset parameters will be ignored by the caller.
+ *
+ * TODO: Right now the imagefilters sometimes return empty result bitmaps/
+ * specialimages. That doesn't seem quite right.
*/
- bool filterImageDeprecated(Proxy*, const SkBitmap& src, const Context&,
- SkBitmap* result, SkIPoint* offset) const;
-
SkSpecialImage* filterImage(SkSpecialImage* src, const Context&, SkIPoint* offset) const;
enum MapDirection {
@@ -460,6 +459,9 @@ private:
friend class SkGraphics;
static void PurgeCache();
+ bool filterImageDeprecated(Proxy*, const SkBitmap& src, const Context&,
+ SkBitmap* result, SkIPoint* offset) const;
+
bool usesSrcInput() const { return fUsesSrcInput; }
typedef SkFlattenable INHERITED;
« no previous file with comments | « no previous file | src/core/SkCanvas.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698