Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1761983003: [Android WebView] Implement support for Network Information API and enable it. (Closed)

Created:
4 years, 9 months ago by timvolodine
Modified:
4 years, 9 months ago
Reviewers:
Torne
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Implement support for Network Information API and enable it. Merge into m50. Currently Network Information API and everything related to the NetworkChangeNotifier is disabled in WebView. This patch implements the required parts to enable Network Information API in WebView. The WebView implementation is based on NetworkChangeNotifier, similar to chrome for Android. However the registration policy is different: 1. whether we listen to network changes depends on the presence of live WebView instances, 2. both the band-width and connectivity changes are propagated, but a reduced network stack is involved as compared to the chrome for android implementation, 3. for backward compatibility invoking setNetworkAvailable() on a webview disables network information api. 4. The embedding application needs to have ACCESS_NETWORK_STATE permission at the time webview process is initialized for the Network Information API to work. BUG=520088, 590383 TBR=torne@chromium.org Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f Cr-Commit-Position: refs/heads/master@{#376975} Review URL: https://codereview.chromium.org/1659363003 Cr-Commit-Position: refs/heads/master@{#378807} (cherry picked from commit bbaeb5b26d3ba544e801a2ad9f31955eb2309d89) Committed: https://chromium.googlesource.com/chromium/src/+/b6d9df41994327103198921c3a7881f0d7fc9202

Patch Set 1 #

Messages

Total messages: 5 (3 generated)
timvolodine
4 years, 9 months ago (2016-03-03 19:46:09 UTC) #3
timvolodine
4 years, 9 months ago (2016-03-03 19:49:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6d9df41994327103198921c3a7881f0d7fc9202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698