[Android WebView] Implement support for Network Information API and enable it.

[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs to have ACCESS_NETWORK_STATE
permission at the time webview process is initialized for the Network
Information API to work.

BUG=520088, 590383
Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}

Committed: https://crrev.com/bbaeb5b26d3ba544e801a2ad9f31955eb2309d89
Cr-Commit-Position: refs/heads/master@{#378807}

[timvolodine, 2016-02-03 16:29:52]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to chrome for
android.

BUG=520088
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation.

BUG=520088
==========

[timvolodine, 2016-02-03 16:48:02]

timvolodine@chromium.org changed reviewers:
+ pauljensen@chromium.org, torne@chromium.org

[timvolodine, 2016-02-03 16:48:03]

torne@: for android_webview/
pauljensen@: for NetworkChangeNotifier.java

[pauljensen, 2016-02-03 17:04:16]

I don't think any NetworkChangeNotifier.java changes are really necessary.

https://codereview.chromium.org/1659363003/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifier.java (right):

https://codereview.chromium.org/1659363003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifier.java:150: public
static void disable() {
why not just call setAutoDetectConnectivityState(false)?

https://codereview.chromium.org/1659363003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifier.java:185:
NetworkChangeNotifierAutoDetect.RegistrationPolicy policy) {
enableWithPolicy() looks just like this function, please remove your's.

[timvolodine, 2016-02-04 18:16:32]

Thanks Paul! I've addressed your comments.

https://codereview.chromium.org/1659363003/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifier.java (right):

https://codereview.chromium.org/1659363003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifier.java:150: public
static void disable() {
On 2016/02/03 17:04:16, pauljensen wrote:
> why not just call setAutoDetectConnectivityState(false)?

Done.

https://codereview.chromium.org/1659363003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifier.java:185:
NetworkChangeNotifierAutoDetect.RegistrationPolicy policy) {
On 2016/02/03 17:04:16, pauljensen wrote:
> enableWithPolicy() looks just like this function, please remove your's.

indeed, apparently I added this function some time ago.. started to repeat
myself ;)
Done.

[Torne, 2016-02-12 16:44:31]

LGTM - this seems like pretty reasonable plumbing of the pieces you've put in
place :)

[Torne, 2016-02-12 16:44:31]

LGTM - this seems like pretty reasonable plumbing of the pieces you've put in
place :)

[timvolodine, 2016-02-23 13:02:06]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation.

BUG=520088
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088
==========

[timvolodine, 2016-02-23 13:36:46]

On 2016/02/12 16:44:31, Torne wrote:
> LGTM - this seems like pretty reasonable plumbing of the pieces you've put in
> place :)

thanks for the reviews!

[timvolodine, 2016-02-23 13:37:23]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-02-23 13:37:24]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/1659363003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-23 13:37:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659363003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659363003/100001

[commit-bot: I haz the power, 2016-02-23 13:43:44]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088
==========

[commit-bot: I haz the power, 2016-02-23 13:43:44]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-23 13:45:17]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

[commit-bot: I haz the power, 2016-02-23 13:45:17]

Patchset 6 (id:??) landed as
https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}

[sgurun-gerrit only, 2016-02-26 23:50:54]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1745663003/ by sgurun@chromium.org.

The reason for reverting is: caused crbug/590383.

[timvolodine, 2016-03-01 20:39:49]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

[timvolodine, 2016-03-01 20:42:10]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

BUG=520088

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

The embedding application needs ACCESS_NETWORK_STATE
permission for the Network Information API to work.

BUG=520088

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

[timvolodine, 2016-03-01 20:48:02]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

The embedding application needs ACCESS_NETWORK_STATE
permission for the Network Information API to work.

BUG=520088

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

The embedding application needs ACCESS_NETWORK_STATE
permission for the Network Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

[timvolodine, 2016-03-01 22:59:38]

On 2016/02/26 23:50:54, sgurun wrote:
> A revert of this CL (patchset #6 id:100001) has been created in
> https://codereview.chromium.org/1745663003/ by mailto:sgurun@chromium.org.
> 
> The reason for reverting is: caused crbug/590383.

FYI
okay, uploaded a fix with a check for ACCESS_NETWORK_STATE permission; updated
description; will reland once all bots are happy

[timvolodine, 2016-03-01 23:01:27]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.

The embedding application needs ACCESS_NETWORK_STATE
permission for the Network Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs ACCESS_NETWORK_STATE
permission for the Network Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

[timvolodine, 2016-03-02 02:04:14]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs ACCESS_NETWORK_STATE
permission for the Network Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs to have ACCESS_NETWORK_STATE
permission at the time webview process is initialized for the Network
Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

[timvolodine, 2016-03-02 19:51:52]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-03-02 19:51:52]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/1659363003/#ps160001
(title: "remove logging")

[commit-bot: I haz the power, 2016-03-02 19:52:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659363003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659363003/160001

[commit-bot: I haz the power, 2016-03-02 19:58:54]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs to have ACCESS_NETWORK_STATE
permission at the time webview process is initialized for the Network
Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs to have ACCESS_NETWORK_STATE
permission at the time webview process is initialized for the Network
Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

[commit-bot: I haz the power, 2016-03-02 19:58:55]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-02 20:00:53]

Description was changed from

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs to have ACCESS_NETWORK_STATE
permission at the time webview process is initialized for the Network
Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}
==========

to

==========
[Android WebView] Implement support for Network Information API and enable it.

Currently Network Information API and everything related to the
NetworkChangeNotifier is disabled in WebView. This patch implements
the required parts to enable Network Information API in WebView.

The WebView implementation is based on NetworkChangeNotifier,
similar to chrome for Android. However the registration policy
is different:
1. whether we listen to network changes depends on the presence
of live WebView instances,
2. both the band-width and connectivity changes are propagated,
but a reduced network stack is involved as compared to the chrome
for android implementation,
3. for backward compatibility invoking setNetworkAvailable() on a
webview disables network information api.
4. The embedding application needs to have ACCESS_NETWORK_STATE
permission at the time webview process is initialized for the Network
Information API to work.

BUG=520088, 590383

Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f
Cr-Commit-Position: refs/heads/master@{#376975}

Committed: https://crrev.com/bbaeb5b26d3ba544e801a2ad9f31955eb2309d89
Cr-Commit-Position: refs/heads/master@{#378807}
==========

[commit-bot: I haz the power, 2016-03-02 20:00:54]

Patchset 9 (id:??) landed as
https://crrev.com/bbaeb5b26d3ba544e801a2ad9f31955eb2309d89
Cr-Commit-Position: refs/heads/master@{#378807}