Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1761943002: SafeJSON: Remove unneeded deps for Android builds. (Closed)

Created:
4 years, 9 months ago by Kevin M
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SafeJSON: Remove unneeded deps for Android builds. Remove unneeded deps for Android builds. Some Android-based dependents of safe_json are unable to link //content as a matter of policy, which is creating linker errors. * Remove //content/public/browser (don't need BrowserThread) * Remove utility process IPC messages dep. R=bauerb@chromium.org,rsesek@chromium.org BUG= Committed: https://crrev.com/f6a64e11ecacf56a75bca45ff25878fb2baaf076 Cr-Commit-Position: refs/heads/master@{#379055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/safe_json/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kevin M
4 years, 9 months ago (2016-03-03 18:46:09 UTC) #1
Robert Sesek
LGTM
4 years, 9 months ago (2016-03-03 19:15:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761943002/1
4 years, 9 months ago (2016-03-03 19:20:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 19:26:24 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 19:45:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6a64e11ecacf56a75bca45ff25878fb2baaf076
Cr-Commit-Position: refs/heads/master@{#379055}

Powered by Google App Engine
This is Rietveld 408576698