Shut down all threads before the main thread shuts down

content/browser/renderer_host/sandbox_ipc_linux.cc

Index: content/browser/renderer_host/sandbox_ipc_linux.cc
diff --git a/content/browser/renderer_host/sandbox_ipc_linux.cc b/content/browser/renderer_host/sandbox_ipc_linux.cc
index 8fb50d4738fdef1bfd5406c0c124e019a5a3376b..186c4f4c0d43b98ef417357b687084b2d02035a7 100644
--- a/content/browser/renderer_host/sandbox_ipc_linux.cc
+++ b/content/browser/renderer_host/sandbox_ipc_linux.cc
@@ -120,6 +120,9 @@ void SandboxIPCHandler::Run() {
     }
   }
 
+  if (blink_platform_impl_)
+    blink::shutdownWithoutV8();

[kinuko, 2016/03/07 06:36:56]

Yeah this'd work.

[sof, 2016/03/07 07:54:03]

naive question: would things break horribly if this called blink::shutdown() ?

[haraken, 2016/03/07 08:02:34]

Do you mean we should call blink::initialize() and blink::shutdown()? I think it
will just initialize more things (i.e., V8) than needed. Actually, as kinuko-san
pointed out before, initializeWithoutV8 would be already too much for the call
sites. Initializing WebFonts etc would be enough.

Calling blink::initializeWithoutV8() and blink::shutdown() will break things at
the shutdown.

[sof, 2016/03/07 08:20:38]

ok, thanks. And allocating via Oilpan is an unavoidable Blink extra, hence it
needs to be in the "withoutV8" subset. (Not that it was prior to this.)

[haraken, 2016/03/07 08:24:03]

Yes. Heap::init was already in initializeWithoutV8 (before this CL).

+
   VLOG(1) << "SandboxIPCHandler stopping.";
 }
 
@@ -434,9 +437,6 @@ void SandboxIPCHandler::SendRendererReply(
 }
 
 SandboxIPCHandler::~SandboxIPCHandler() {
-  if (blink_platform_impl_)
-    blink::shutdownWithoutV8();
-
   if (IGNORE_EINTR(close(lifeline_fd_)) < 0)
     PLOG(ERROR) << "close";
   if (IGNORE_EINTR(close(browser_socket_)) < 0)