Shut down all threads before the main thread shuts down

content/browser/renderer_host/sandbox_ipc_linux.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/sandbox_ipc_linux.h"
 
 #include <fcntl.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
@@ skipping 102 matching lines @@
     // we assume the zygote is gone and we exit the loop.
     if (pfds[1].revents & (POLLERR | POLLHUP)) {
       break;
     }
 
     if (pfds[1].revents & POLLIN) {
       HandleRequestFromRenderer(browser_socket_);
     }
   }
 
+  if (blink_platform_impl_)
+    blink::shutdownWithoutV8();

[kinuko, 2016/03/07 06:36:56]

Yeah this'd work.

[sof, 2016/03/07 07:54:03]

naive question: would things break horribly if this called blink::shutdown() ?

[haraken, 2016/03/07 08:02:34]

Do you mean we should call blink::initialize() and blink::shutdown()? I think it
will just initialize more things (i.e., V8) than needed. Actually, as kinuko-san
pointed out before, initializeWithoutV8 would be already too much for the call
sites. Initializing WebFonts etc would be enough.

Calling blink::initializeWithoutV8() and blink::shutdown() will break things at
the shutdown.

[sof, 2016/03/07 08:20:38]

ok, thanks. And allocating via Oilpan is an unavoidable Blink extra, hence it
needs to be in the "withoutV8" subset. (Not that it was prior to this.)

[haraken, 2016/03/07 08:24:03]

Yes. Heap::init was already in initializeWithoutV8 (before this CL).

+
   VLOG(1) << "SandboxIPCHandler stopping.";
 }
 
 void SandboxIPCHandler::HandleRequestFromRenderer(int fd) {
   std::vector<base::ScopedFD> fds;
 
   // A FontConfigIPC::METHOD_MATCH message could be kMaxFontFamilyLength
   // bytes long (this is the largest message type).
   // 128 bytes padding are necessary so recvmsg() does not return MSG_TRUNC
   // error for a maximum length message.
@@ skipping 294 matching lines @@
     cmsg->cmsg_len = CMSG_LEN(sizeof(int));
     memcpy(CMSG_DATA(cmsg), &reply_fd, sizeof(reply_fd));
     msg.msg_controllen = cmsg->cmsg_len;
   }
 
   if (HANDLE_EINTR(sendmsg(fds[0].get(), &msg, MSG_DONTWAIT)) < 0)
     PLOG(ERROR) << "sendmsg";
 }
 
 SandboxIPCHandler::~SandboxIPCHandler() {
-  if (blink_platform_impl_)
-    blink::shutdownWithoutV8();
-
   if (IGNORE_EINTR(close(lifeline_fd_)) < 0)
     PLOG(ERROR) << "close";
   if (IGNORE_EINTR(close(browser_socket_)) < 0)
     PLOG(ERROR) << "close";
 }
 
 void SandboxIPCHandler::EnsureWebKitInitialized() {
   if (blink_platform_impl_)
     return;
   blink_platform_impl_.reset(new BlinkPlatformImpl);
   blink::initializeWithoutV8(blink_platform_impl_.get());
 }
 
 }  // namespace content