[Closure Externs] Add more APIs to the presubmit warning list

[Closure Externs] Add more APIs to the presubmit warning list

Add a bunch of private APIs to the list that will get presubmit checks. Also
normalize the paths and check that each exists.

BUG=469920
Committed: https://crrev.com/953fd79d9cebebe12504985d3ef1c9291047425a
Cr-Commit-Position: refs/heads/master@{#380488}

[Devlin, 2016-03-02 23:28:11]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-03-03 00:24:20]

lgtm

https://codereview.chromium.org/1761663002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/PRESUBMIT.py (right):

https://codereview.chromium.org/1761663002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/PRESUBMIT.py:16: 
join = input_api.os_path.join
api_root = input_api.PresubmitLocalPath()
src_root = join(api_root, '..', '..', '..', '..')

try:
  sys.path.append(join(src_root, 'extensions', 'common', 'api'))
...

externs_root = join(src_root, 'third_party', 'closure_compiler', 'externs')

https://codereview.chromium.org/1761663002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/PRESUBMIT.py:47: normpath(join(externs_root, v))
for k, v in api_pair_names.items()
mind == blown

[Devlin, 2016-03-07 19:49:29]

Sorry for leaving this hanging - other things came up that stole my attention.

Please also take a quick look at the test modifications.

https://codereview.chromium.org/1761663002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/PRESUBMIT.py (right):

https://codereview.chromium.org/1761663002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/PRESUBMIT.py:16: 
On 2016/03/03 00:24:20, Dan Beam wrote:
> join = input_api.os_path.join
> api_root = input_api.PresubmitLocalPath()
> src_root = join(api_root, '..', '..', '..', '..')
> 
> try:
>   sys.path.append(join(src_root, 'extensions', 'common', 'api'))
> ...
> 
> externs_root = join(src_root, 'third_party', 'closure_compiler', 'externs')

I like it.  Done.

https://codereview.chromium.org/1761663002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/PRESUBMIT.py:47: normpath(join(externs_root, v))
for k, v in api_pair_names.items()
On 2016/03/03 00:24:20, Dan Beam wrote:
> mind == blown

Yay for python!

[Devlin, 2016-03-10 21:46:51]

friendly ping -> Dan

[Dan Beam, 2016-03-10 22:15:35]

still lgtm

[Devlin, 2016-03-10 22:17:19]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:18:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761663002/40001

[commit-bot: I haz the power, 2016-03-10 23:26:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-10 23:27:49]

Description was changed from

==========
[Closure Externs] Add more APIs to the presubmit warning list

Add a bunch of private APIs to the list that will get presubmit checks. Also
normalize the paths and check that each exists.

BUG=469920
==========

to

==========
[Closure Externs] Add more APIs to the presubmit warning list

Add a bunch of private APIs to the list that will get presubmit checks. Also
normalize the paths and check that each exists.

BUG=469920

Committed: https://crrev.com/953fd79d9cebebe12504985d3ef1c9291047425a
Cr-Commit-Position: refs/heads/master@{#380488}
==========

[commit-bot: I haz the power, 2016-03-10 23:27:50]

Patchset 3 (id:??) landed as
https://crrev.com/953fd79d9cebebe12504985d3ef1c9291047425a
Cr-Commit-Position: refs/heads/master@{#380488}