Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: extensions/common/api/externs_checker.py

Issue 1761663002: [Closure Externs] Add more APIs to the presubmit warning list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/PRESUBMIT.py ('k') | extensions/common/api/externs_checker_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/externs_checker.py
diff --git a/extensions/common/api/externs_checker.py b/extensions/common/api/externs_checker.py
index 58c0076f8cec0378898334db76a6a0ba5156fb79..fd60fdd87df4901e4679f3d7e25845caf1d0523d 100644
--- a/extensions/common/api/externs_checker.py
+++ b/extensions/common/api/externs_checker.py
@@ -12,6 +12,10 @@ class ExternsChecker(object):
self._output_api = output_api
self._api_pairs = api_pairs
+ for path in api_pairs.keys() + api_pairs.values():
+ if not input_api.os_path.exists(path):
+ raise OSError('Path Not Found: %s' % path)
+
def RunChecks(self):
bad_files = []
affected = [f.AbsoluteLocalPath() for f in self._input_api.AffectedFiles()]
« no previous file with comments | « chrome/common/extensions/api/PRESUBMIT.py ('k') | extensions/common/api/externs_checker_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698