Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1761523002: Retract GrDrawTarget and GrPipelineBuilder a bit more (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M src/gpu/GrTracing.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 chunk +13 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.h View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +7 lines, -14 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
4 years, 9 months ago (2016-03-02 18:31:27 UTC) #5
joshualitt
On 2016/03/02 18:31:27, robertphillips wrote: lGtm
4 years, 9 months ago (2016-03-02 18:37:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761523002/1
4 years, 9 months ago (2016-03-02 18:40:32 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/849)
4 years, 9 months ago (2016-03-02 18:42:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761523002/1
4 years, 9 months ago (2016-03-02 19:35:41 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 19:37:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/73c4e64f4bb90059cf822dac9eaf30e1c38bec77

Powered by Google App Engine
This is Rietveld 408576698