Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: runtime/observatory/tests/service/service_test_common.dart

Issue 1761503002: Simplify pause_idle_isolate_test and add more debugging output. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/pause_idle_isolate_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/service_test_common.dart
diff --git a/runtime/observatory/tests/service/service_test_common.dart b/runtime/observatory/tests/service/service_test_common.dart
index 7435ee5c0fde984d2fe2fcf26e60c26971a94b91..872d994c547bdcc38032eab6ef9bdbe37ff4d638 100644
--- a/runtime/observatory/tests/service/service_test_common.dart
+++ b/runtime/observatory/tests/service/service_test_common.dart
@@ -88,10 +88,10 @@ Future<Isolate> hasPausedFor(Isolate isolate, String kind) {
var subscription;
subscription = stream.listen((ServiceEvent event) {
if (event.kind == kind) {
- print('Paused with $kind');
- subscription.cancel();
if (completer != null) {
// Reload to update isolate.pauseEvent.
+ print('Paused with $kind');
+ subscription.cancel();
completer.complete(isolate.reload());
completer = null;
}
@@ -103,9 +103,9 @@ Future<Isolate> hasPausedFor(Isolate isolate, String kind) {
if ((isolate.pauseEvent != null) &&
(isolate.pauseEvent.kind == kind)) {
// Already waiting at a breakpoint.
- print('Paused with $kind');
- subscription.cancel();
if (completer != null) {
+ print('Paused with $kind');
+ subscription.cancel();
completer.complete(isolate);
completer = null;
}
« no previous file with comments | « runtime/observatory/tests/service/pause_idle_isolate_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698