Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1987)

Unified Diff: runtime/observatory/tests/service/pause_idle_isolate_test.dart

Issue 1761503002: Simplify pause_idle_isolate_test and add more debugging output. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/service_test_common.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/pause_idle_isolate_test.dart
diff --git a/runtime/observatory/tests/service/pause_idle_isolate_test.dart b/runtime/observatory/tests/service/pause_idle_isolate_test.dart
index cfd418ce37bac2a5d426e74a858af092ad4bb447..a75dcd11fcacca0f78d2ca65b62da6ff5e501813 100644
--- a/runtime/observatory/tests/service/pause_idle_isolate_test.dart
+++ b/runtime/observatory/tests/service/pause_idle_isolate_test.dart
@@ -3,55 +3,28 @@
// BSD-style license that can be found in the LICENSE file.
// VMOptions=--error_on_bad_type --error_on_bad_override
-import 'package:observatory/service_io.dart';
-import 'package:unittest/unittest.dart';
-import 'test_helper.dart';
import 'dart:async';
+import 'dart:developer';
import 'dart:io';
import 'dart:isolate' show ReceivePort;
+import 'package:observatory/service_io.dart';
+import 'package:unittest/unittest.dart';
+import 'service_test_common.dart';
+import 'test_helper.dart';
var receivePort;
void testMain() {
receivePort = new ReceivePort();
+ debugger();
}
var tests = [
-(Isolate isolate) async {
- Completer completer = new Completer();
- var stream = await isolate.vm.getEventStream(VM.kDebugStream);
- var subscription;
- subscription = stream.listen((ServiceEvent event) {
- if (event.kind == ServiceEvent.kPauseStart) {
- print('Received $event');
- subscription.cancel();
- completer.complete();
- }
- });
-
- if (isolate.pauseEvent != null &&
- isolate.pauseEvent.kind == ServiceEvent.kPauseStart) {
- // Wait for the isolate to hit PauseStart.
- subscription.cancel();
- } else {
- await completer.future;
- }
- print('Done waiting for pause event.');
-
- // Wait for the isolate to pause due to interruption.
- completer = new Completer();
- stream = await isolate.vm.getEventStream(VM.kDebugStream);
- bool receivedInterrupt = false;
- subscription = stream.listen((ServiceEvent event) {
- print('Received $event');
- if (event.kind == ServiceEvent.kPauseInterrupted) {
- receivedInterrupt = true;
- subscription.cancel();
- completer.complete();
- }
- });
+hasStoppedAtBreakpoint,
+(Isolate isolate) async {
+ print('Resuming...');
await isolate.resume();
// Wait for the isolate to become idle. We detect this by querying
@@ -60,21 +33,24 @@ var tests = [
do {
var stack = await isolate.getStack();
frameCount = stack['frames'].length;
- print('frames: $frameCount');
+ print('Frames: $frameCount');
sleep(const Duration(milliseconds:10));
} while (frameCount > 0);
+ print('Isolate is idle.');
+ await isolate.reload();
+ expect(isolate.pauseEvent.kind, equals(ServiceEvent.kResume));
// Make sure that the isolate receives an interrupt even when it is
// idle. (https://github.com/dart-lang/sdk/issues/24349)
+ var interruptFuture = hasPausedFor(isolate, ServiceEvent.kPauseInterrupted);
+ print('Pausing...');
await isolate.pause();
- await completer.future;
- expect(receivedInterrupt, isTrue);
+ await interruptFuture;
},
];
main(args) => runIsolateTests(args, tests,
testeeConcurrent: testMain,
- pause_on_start: true,
trace_service: true,
verbose_vm: true);
« no previous file with comments | « no previous file | runtime/observatory/tests/service/service_test_common.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698