Issue 1761503002: Simplify pause_idle_isolate_test and add more debugging output.

Issue 1761503002: Simplify pause_idle_isolate_test and add more debugging output. (Closed)

Created:
4 years, 9 months ago by turnidge

Modified:
4 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Simplify pause_idle_isolate_test and add more debugging output. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/2284cfe8392af7168564b6dace928040001aa743

Patch Set 5 : #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -44 lines)			Patch
	M	runtime/observatory/tests/service/pause_idle_isolate_test.dart	View	1 2 3	2 chunks	+16 lines, -40 lines	0 comments	Download
	M	runtime/observatory/tests/service/service_test_common.dart	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

LGTM with a question/suggestion. https://codereview.chromium.org/1761503002/diff/20001/runtime/observatory/tests/service/pause_idle_isolate_test.dart File runtime/observatory/tests/service/pause_idle_isolate_test.dart (right): https://codereview.chromium.org/1761503002/diff/20001/runtime/observatory/tests/service/pause_idle_isolate_test.dart#newcode32 runtime/observatory/tests/service/pause_idle_isolate_test.dart:32: subscription = stream.listen((ServiceEvent event) { ...

4 years, 9 months ago (2016-03-02 17:42:16 UTC) #3

turnidge

4 years, 9 months ago (2016-03-02 18:01:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
2284cfe8392af7168564b6dace928040001aa743 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages