Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_api.cc

Issue 1761303003: Remove extra Release in pageCapture extension function implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/page_capture/page_capture_api.cc
diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.cc b/chrome/browser/extensions/api/page_capture/page_capture_api.cc
index ba0fd507ef1bcf6dce6f64c314f298cfbcfc11c1..4707e6410daf5769df34757c3dd1d9bb7e17f1ed 100644
--- a/chrome/browser/extensions/api/page_capture/page_capture_api.cc
+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.cc
@@ -157,7 +157,7 @@ void PageCaptureSaveAsMHTMLFunction::ReturnFailure(const std::string& error) {
SendResponse(false);
- Release(); // Balanced in Run()
+ // Must not Release() here, OnMessageReceived will call it eventually.
Devlin 2016/03/04 20:31:15 Wow, this function is crazy.
meacer 2016/03/04 20:37:59 Well, at least there is only one AddRef()/Release(
}
void PageCaptureSaveAsMHTMLFunction::ReturnSuccess(int64_t file_size) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698