Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761303003: Remove extra Release in pageCapture extension function implementation. (Closed)

Created:
4 years, 9 months ago by meacer
Modified:
4 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove extra Release in pageCapture extension function implementation. BUG=401364 Committed: https://crrev.com/587ba472dfefe862855487c4e6faee859b686160 Cr-Commit-Position: refs/heads/master@{#379361}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9 (3 generated)
meacer
Devlin, PTAL?
4 years, 9 months ago (2016-03-04 20:23:27 UTC) #2
Devlin
lgtm https://codereview.chromium.org/1761303003/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc File chrome/browser/extensions/api/page_capture/page_capture_api.cc (right): https://codereview.chromium.org/1761303003/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc#newcode160 chrome/browser/extensions/api/page_capture/page_capture_api.cc:160: // Must not Release() here, OnMessageReceived will call ...
4 years, 9 months ago (2016-03-04 20:31:15 UTC) #3
meacer
https://codereview.chromium.org/1761303003/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc File chrome/browser/extensions/api/page_capture/page_capture_api.cc (right): https://codereview.chromium.org/1761303003/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc#newcode160 chrome/browser/extensions/api/page_capture/page_capture_api.cc:160: // Must not Release() here, OnMessageReceived will call it ...
4 years, 9 months ago (2016-03-04 20:37:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761303003/1
4 years, 9 months ago (2016-03-04 20:38:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 21:24:14 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 21:26:25 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/587ba472dfefe862855487c4e6faee859b686160
Cr-Commit-Position: refs/heads/master@{#379361}

Powered by Google App Engine
This is Rietveld 408576698