third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js - Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prepare-bindings-module

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js b/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

index ca45d5128875c93244cf5767ee4f1a48c8c0d66a..cbd184de7d2086e19e16eeaaa240fe03e1681299 100644

--- a/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

@@ -895,7 +895,7 @@ WebInspector.AnimationModel.ScreenshotCapture.prototype = {

{

var screencastDuration = Math.min(duration / this._model._playbackRate, 3000);

var endTime = screencastDuration + window.performance.now();

- this._requests.push({ endTime: endTime, screenshots: screenshots });

+ this._requests.push({ time: endTime, screenshots: screenshots });

lushnikov 2016/03/04 05:06:58 it should be endTime; the typedef is wrong.

kozy 2016/03/04 06:13:29 Done.

if (!this._endTime || endTime > this._endTime) {

clearTimeout(this._stopTimer);