Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761173003: [wasm] Update {i32,i64}.const to use signed leb128 (Closed)

Created:
4 years, 9 months ago by binji
Modified:
4 years, 9 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
http://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Committed: https://crrev.com/af193e7534e3eee6452cea6213c6db2357f19e33 Cr-Commit-Position: refs/heads/master@{#34506}

Patch Set 1 #

Patch Set 2 : compile fix + merge namespaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -308 lines) Patch
M src/wasm/asm-wasm-builder.cc View 6 chunks +11 lines, -6 lines 0 comments Download
M src/wasm/ast-decoder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/decoder.h View 1 4 chunks +21 lines, -6 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 2 chunks +140 lines, -13 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 19 chunks +52 lines, -18 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 3 chunks +15 lines, -198 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 10 chunks +49 lines, -49 lines 0 comments Download
M test/unittests/wasm/decoder-unittest.cc View 3 chunks +41 lines, -2 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
4 years, 9 months ago (2016-03-04 18:45:30 UTC) #1
titzer
lgtm
4 years, 9 months ago (2016-03-04 19:00:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761173003/20001
4 years, 9 months ago (2016-03-04 19:03:52 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 19:05:52 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 19:06:41 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/af193e7534e3eee6452cea6213c6db2357f19e33
Cr-Commit-Position: refs/heads/master@{#34506}

Powered by Google App Engine
This is Rietveld 408576698