[wasm] Update {i32,i64}.const to use signed leb128

[wasm] Update {i32,i64}.const to use signed leb128

R=titzer@chromium.org
R=bradnelson@chromium.org
LOG=n

Committed: https://crrev.com/4b613a67e0aa4e073946f5f0dd95ee9366c8ca86
Cr-Commit-Position: refs/heads/master@{#34471}

[titzer, 2016-03-03 23:22:53]

lgtm

https://codereview.chromium.org/1765673002/diff/20001/src/wasm/wasm-macro-gen.h
File src/wasm/wasm-macro-gen.h (right):

https://codereview.chromium.org/1765673002/diff/20001/src/wasm/wasm-macro-gen...
src/wasm/wasm-macro-gen.h:95: namespace v8 {
You can combine these namespaces.

https://codereview.chromium.org/1765673002/diff/20001/test/unittests/wasm/ast...
File test/unittests/wasm/ast-decoder-unittest.cc (right):

https://codereview.chromium.org/1765673002/diff/20001/test/unittests/wasm/ast...
test/unittests/wasm/ast-decoder-unittest.cc:221: TEST_F(AstDecoderTest,
Int32Const) {
Can you drop in a TODO to expand this test for 1, 2, 3, 4, and 5 byte sizes?

[binji, 2016-03-03 23:47:32]

https://codereview.chromium.org/1765673002/diff/20001/src/wasm/wasm-macro-gen.h
File src/wasm/wasm-macro-gen.h (right):

https://codereview.chromium.org/1765673002/diff/20001/src/wasm/wasm-macro-gen...
src/wasm/wasm-macro-gen.h:95: namespace v8 {
On 2016/03/03 23:22:52, titzer wrote:
> You can combine these namespaces.

Sorry, not sure what you mean... is this some new C++11 thing?

https://codereview.chromium.org/1765673002/diff/20001/test/unittests/wasm/ast...
File test/unittests/wasm/ast-decoder-unittest.cc (right):

https://codereview.chromium.org/1765673002/diff/20001/test/unittests/wasm/ast...
test/unittests/wasm/ast-decoder-unittest.cc:221: TEST_F(AstDecoderTest,
Int32Const) {
On 2016/03/03 23:22:52, titzer wrote:
> Can you drop in a TODO to expand this test for 1, 2, 3, 4, and 5 byte sizes?

Done.

[binji, 2016-03-04 00:09:52]

The CQ bit was checked by binji@chromium.org

[binji, 2016-03-04 00:09:53]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1765673002/#ps40001
(title: "nits, WASM_I64V fixes")

[commit-bot: I haz the power, 2016-03-04 00:09:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765673002/40001

[commit-bot: I haz the power, 2016-03-04 00:11:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-04 00:12:50]

Description was changed from

==========
[wasm] Update {i32,i64}.const to use signed leb128

R=titzer@chromium.org
R=bradnelson@chromium.org
LOG=n
==========

to

==========
[wasm] Update {i32,i64}.const to use signed leb128

R=titzer@chromium.org
R=bradnelson@chromium.org
LOG=n

Committed: https://crrev.com/4b613a67e0aa4e073946f5f0dd95ee9366c8ca86
Cr-Commit-Position: refs/heads/master@{#34471}
==========

[commit-bot: I haz the power, 2016-03-04 00:12:51]

Patchset 3 (id:??) landed as
https://crrev.com/4b613a67e0aa4e073946f5f0dd95ee9366c8ca86
Cr-Commit-Position: refs/heads/master@{#34471}

[Michael Achenbach, 2016-03-04 09:01:34]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1760363003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks chromium win compile:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/384....