fpdfsdk/include/jsapi/fxjs_v8.h - Issue 1761073006: Re-land "Only place primitive objects on the V8 global template.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/jsapi/fxjs_v8.h

Issue 1761073006: Re-land "Only place primitive objects on the V8 global template."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Better solution - destroy handles before runtime. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/jsapi/fxjs_v8.h

diff --git a/fpdfsdk/include/jsapi/fxjs_v8.h b/fpdfsdk/include/jsapi/fxjs_v8.h

index 76373ac4bc4e6ba7c36e74965e8773da396a9d3c..64fa01bd4465176111400c71d6e9f7dfac0e8be8 100644

--- a/fpdfsdk/include/jsapi/fxjs_v8.h

+++ b/fpdfsdk/include/jsapi/fxjs_v8.h

@@ -188,7 +188,7 @@ void FXJS_DefineGlobalMethod(v8::Isolate* pIsolate,

v8::FunctionCallback pMethodCall);

void FXJS_DefineGlobalConst(v8::Isolate* pIsolate,

const wchar_t* sConstName,

- v8::Local<v8::Value> pDefault);

+ v8::FunctionCallback pConstGetter);

// Called after FXJS_Define* calls made.

void FXJS_InitializeRuntime(

« no previous file with comments | « no previous file | fpdfsdk/src/javascript/Consts.cpp » ('j') | no next file with comments »