Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: components/dom_distiller_resources.grdp

Issue 176083002: Use boilerpipe-based dom-distiller-js (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller_resources.grdp
diff --git a/components/dom_distiller_resources.grdp b/components/dom_distiller_resources.grdp
index bb2092edc8f66787e1f1980b0bb83530671f9d3a..56363e23294655573f76e9bb5b4972eec5558ec5 100644
--- a/components/dom_distiller_resources.grdp
+++ b/components/dom_distiller_resources.grdp
@@ -4,6 +4,7 @@
<include name="IDR_ABOUT_DOM_DISTILLER_CSS" file="dom_distiller/webui/resources/about_dom_distiller.css" type="BINDATA" />
<include name="IDR_ABOUT_DOM_DISTILLER_JS" file="dom_distiller/webui/resources/about_dom_distiller.js" type="BINDATA" />
<include name="IDR_DOM_DISTILLER_VIEWER_HTML" file="dom_distiller/content/resources/dom_distiller_viewer.html" type="BINDATA" />
- <include name="IDR_DISTILLER_JS" file="../third_party/readability/js/readability.js" type="BINDATA" />
<include name="IDR_DISTILLER_CSS" file="../third_party/readability/css/readability.css" type="BINDATA" />
+ <include name="IDR_DISTILLER_JS" file="dom_distiller/core/javascript/domdistiller.js" flattenhtml="true" allowexternalscript="true" type="BINDATA" />
Yaron 2014/02/26 02:50:50 Does this end up in us having two copies of readab
cjhopman 2014/02/27 02:43:09 Yeah. I've just removed this one. If we want to ru
+ <include name="IDR_DISTILLER_READABILITY_JS" file="dom_distiller/core/javascript/readability.js" flattenhtml="true" allowexternalscript="true" type="BINDATA" />
</grit-part>

Powered by Google App Engine
This is Rietveld 408576698