components/dom_distiller_resources.grdp - Issue 176083002: Use boilerpipe-based dom-distiller-js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller_resources.grdp

Issue 176083002: Use boilerpipe-based dom-distiller-js (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/dom_distiller/core/javascript/domdistiller.js ('K') | « components/dom_distiller/core/javascript/readability.js ('k') | third_party/dom_distiller_js/LICENSE » ('j') | third_party/dom_distiller_js/LICENSE » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3 <include name="IDR_ABOUT_DOM_DISTILLER_HTML" file="dom_distiller/webui/resourc es/about_dom_distiller.html" flattenhtml="true" allowexternalscript="true" type= "BINDATA" />	3 <include name="IDR_ABOUT_DOM_DISTILLER_HTML" file="dom_distiller/webui/resourc es/about_dom_distiller.html" flattenhtml="true" allowexternalscript="true" type= "BINDATA" />

4 <include name="IDR_ABOUT_DOM_DISTILLER_CSS" file="dom_distiller/webui/resource s/about_dom_distiller.css" type="BINDATA" />	4 <include name="IDR_ABOUT_DOM_DISTILLER_CSS" file="dom_distiller/webui/resource s/about_dom_distiller.css" type="BINDATA" />

5 <include name="IDR_ABOUT_DOM_DISTILLER_JS" file="dom_distiller/webui/resources /about_dom_distiller.js" type="BINDATA" />	5 <include name="IDR_ABOUT_DOM_DISTILLER_JS" file="dom_distiller/webui/resources /about_dom_distiller.js" type="BINDATA" />

6 <include name="IDR_DOM_DISTILLER_VIEWER_HTML" file="dom_distiller/content/reso urces/dom_distiller_viewer.html" type="BINDATA" />	6 <include name="IDR_DOM_DISTILLER_VIEWER_HTML" file="dom_distiller/content/reso urces/dom_distiller_viewer.html" type="BINDATA" />

7 <include name="IDR_DISTILLER_JS" file="../third_party/readability/js/readabili ty.js" type="BINDATA" />

8 <include name="IDR_DISTILLER_CSS" file="../third_party/readability/css/readabi lity.css" type="BINDATA" />	7 <include name="IDR_DISTILLER_CSS" file="../third_party/readability/css/readabi lity.css" type="BINDATA" />

	8 <include name="IDR_DISTILLER_JS" file="dom_distiller/core/javascript/domdistil ler.js" flattenhtml="true" allowexternalscript="true" type="BINDATA" />
	Yaron 2014/02/26 02:50:50 Does this end up in us having two copies of readab Does this end up in us having two copies of readability? One in the boilerpipe version (temporary) and the one that's currently in use? If so, can you make a gyp flag to control which one is included? cjhopman 2014/02/27 02:43:09 Yeah. I've just removed this one. If we want to ru Show quoted text On 2014/02/26 02:50:50, Yaron wrote: > Does this end up in us having two copies of readability? One in the boilerpipe > version (temporary) and the one that's currently in use? If so, can you make a > gyp flag to control which one is included? Yeah. I've just removed this one. If we want to run eval with readability, we can just add a separate set of resources for the standalone content_extractor.
	9 <include name="IDR_DISTILLER_READABILITY_JS" file="dom_distiller/core/javascri pt/readability.js" flattenhtml="true" allowexternalscript="true" type="BINDATA" />

9 </grit-part>	10 </grit-part>

OLD	NEW