Chromium Code Reviews Chromium Code Reviews
Issue 1760823002:
Allow splitter to resize next element (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/test/data/webui/splitter_test.html |
| diff --git a/chrome/test/data/webui/splitter_test.html b/chrome/test/data/webui/splitter_test.html |
| index 9d4a567b82a56797d4a32ba21a8e7b578e73ece8..fca7035c0cc0d3016d7236e57892103d7ef388e8 100644 |
| --- a/chrome/test/data/webui/splitter_test.html |
| +++ b/chrome/test/data/webui/splitter_test.html |
| @@ -1,9 +1,9 @@ |
| <!doctype html> |
| <html> |
| <body> |
| -<div></div> |
| +<div id="previous"></div> |
| <div id="splitter"></div> |
| -<div></div> |
| +<div id="next"></div> |
| <script> |
| function testSplitter_IgnoresRightMouse() { |
| var splitter = document.getElementById('splitter'); |
| @@ -17,6 +17,61 @@ function testSplitter_IgnoresRightMouse() { |
| assertFalse(splitter.dispatchEvent(downLeft)); |
| assertTrue(downLeft.defaultPrevented); |
| } |
|
Dan Beam
2016/03/07 18:14:20
\n
ryoh
2016/03/08 01:24:32
Done.
|
| +function testSplitter_ResizePreviousElement() { |
| + var splitter = document.getElementById('splitter'); |
| + cr.ui.decorate(splitter, cr.ui.Splitter); |
| + splitter.resizeNextElement = false; |
| + |
| + var previousElement = document.getElementById('previous'); |
| + previousElement.style.width = '0px'; |
| + var beforeWidth = parseFloat(previousElement.style.width); |
| + |
| + var down = new MouseEvent('mousedown', |
| + {button: 0, cancelable: true, clientX: 0}); |
| + splitter.dispatchEvent(down); |
| + |
| + var move = new MouseEvent('mousemove', |
| + {button: 0, cancelable: true, clientX: 50}); |
| + splitter.dispatchEvent(move); |
|
Dan Beam
2016/03/07 18:14:19
why do we need this middle 'mousemove'?
ryoh
2016/03/08 01:24:32
I thought it is more natural to add this middle 'm
|
| + |
| + move = new MouseEvent('mousemove', |
| + {button: 0, cancelable: true, clientX: 100}); |
| + splitter.dispatchEvent(move); |
| + |
| + var up = new MouseEvent('mouseup', |
| + {button: 0, cancelable: true, clientX: 100}); |
| + splitter.dispatchEvent(up); |
| + |
| + var afterWidth = parseFloat(previousElement.style.width); |
| + assertEquals(100, afterWidth-beforeWidth); |
|
Dan Beam
2016/03/07 18:14:19
afterWidth - beforeWidth
^ ^
ryoh
2016/03/08 01:24:32
Done.
|
| +} |
| +function testSplitter_ResizeNextElement() { |
|
Dan Beam
2016/03/07 18:14:20
\n
ryoh
2016/03/08 01:24:32
Done.
|
| + var splitter = document.getElementById('splitter'); |
| + cr.ui.decorate(splitter, cr.ui.Splitter, true); |
| + splitter.resizeNextElement = true; |
| + var nextElement = document.getElementById('next'); |
| + nextElement.style.width = '0px'; |
| + var beforeWidth = parseFloat(nextElement.style.width); |
| + |
| + var down = new MouseEvent('mousedown', |
| + {button: 0, cancelable: true, clientX: 100}); |
| + splitter.dispatchEvent(down); |
| + |
| + var move = new MouseEvent('mousemove', |
| + {button: 0, cancelable: true, clientX: 50}); |
| + splitter.dispatchEvent(move); |
|
Dan Beam
2016/03/07 18:14:19
why do we need this middle 'mousemove' as well?
|
| + |
| + move = new MouseEvent('mousemove', |
| + {button: 0, cancelable: true, clientX: 0}); |
| + splitter.dispatchEvent(move); |
| + |
| + var up = new MouseEvent('mouseup', |
| + {button: 0, cancelable: true, clientX: 0}); |
| + splitter.dispatchEvent(up); |
| + |
| + var afterWidth = parseFloat(nextElement.style.width); |
| + assertEquals(100, afterWidth-beforeWidth); |
|
Dan Beam
2016/03/07 18:14:20
afterWidth - beforeWidth
^ ^
ryoh
2016/03/08 01:24:32
Done.
|
| +} |
| </script> |
| </body> |
| </html> |
