chrome/test/data/webui/splitter_test.html - Issue 1760823002: Allow splitter to resize next element

Side by Side Diff: chrome/test/data/webui/splitter_test.html

Issue 1760823002: Allow splitter to resize next element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use setter instead of argument of decorate, and added tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <div></div>	4 <div id="previous"></div>

5 <div id="splitter"></div>	5 <div id="splitter"></div>

6 <div></div>	6 <div id="next"></div>

7 <script>	7 <script>

8 function testSplitter_IgnoresRightMouse() {	8 function testSplitter_IgnoresRightMouse() {

9 var splitter = document.getElementById('splitter');	9 var splitter = document.getElementById('splitter');

10 cr.ui.decorate(splitter, cr.ui.Splitter);	10 cr.ui.decorate(splitter, cr.ui.Splitter);

11	11

12 var downRight = new MouseEvent('mousedown', {button: 1, cancelable: true});	12 var downRight = new MouseEvent('mousedown', {button: 1, cancelable: true});

13 assertTrue(splitter.dispatchEvent(downRight));	13 assertTrue(splitter.dispatchEvent(downRight));

14 assertFalse(downRight.defaultPrevented);	14 assertFalse(downRight.defaultPrevented);

15	15

16 var downLeft = new MouseEvent('mousedown', {button: 0, cancelable: true});	16 var downLeft = new MouseEvent('mousedown', {button: 0, cancelable: true});

17 assertFalse(splitter.dispatchEvent(downLeft));	17 assertFalse(splitter.dispatchEvent(downLeft));

18 assertTrue(downLeft.defaultPrevented);	18 assertTrue(downLeft.defaultPrevented);

19 }	19 }
	Dan Beam 2016/03/07 18:14:20 \n \n ryoh 2016/03/08 01:24:32 Done. Show quoted text On 2016/03/07 18:14:20, Dan Beam wrote: > \n Done.
	20 function testSplitter_ResizePreviousElement() {

	21 var splitter = document.getElementById('splitter');

	22 cr.ui.decorate(splitter, cr.ui.Splitter);

	23 splitter.resizeNextElement = false;

	24

	25 var previousElement = document.getElementById('previous');

	26 previousElement.style.width = '0px';

	27 var beforeWidth = parseFloat(previousElement.style.width);

	28

	29 var down = new MouseEvent('mousedown',

	30 {button: 0, cancelable: true, clientX: 0});

	31 splitter.dispatchEvent(down);

	32

	33 var move = new MouseEvent('mousemove',

	34 {button: 0, cancelable: true, clientX: 50});

	35 splitter.dispatchEvent(move);
	Dan Beam 2016/03/07 18:14:19 why do we need this middle 'mousemove'? why do we need this middle 'mousemove'? ryoh 2016/03/08 01:24:32 I thought it is more natural to add this middle 'm Show quoted text On 2016/03/07 18:14:19, Dan Beam wrote: > why do we need this middle 'mousemove'? I thought it is more natural to add this middle 'mousemove', because a user may cause more than one 'mousemove' events while resizing element.
	36

	37 move = new MouseEvent('mousemove',

	38 {button: 0, cancelable: true, clientX: 100});

	39 splitter.dispatchEvent(move);

	40

	41 var up = new MouseEvent('mouseup',

	42 {button: 0, cancelable: true, clientX: 100});

	43 splitter.dispatchEvent(up);

	44

	45 var afterWidth = parseFloat(previousElement.style.width);

	46 assertEquals(100, afterWidth-beforeWidth);
	Dan Beam 2016/03/07 18:14:19 afterWidth - beforeWidth ^ ^ afterWidth - beforeWidth ^ ^ ryoh 2016/03/08 01:24:32 Done. Show quoted text On 2016/03/07 18:14:19, Dan Beam wrote: > afterWidth - beforeWidth > ^ ^ Done.
	47 }

	48 function testSplitter_ResizeNextElement() {
	Dan Beam 2016/03/07 18:14:20 \n \n ryoh 2016/03/08 01:24:32 Done. Show quoted text On 2016/03/07 18:14:20, Dan Beam wrote: > \n Done.
	49 var splitter = document.getElementById('splitter');

	50 cr.ui.decorate(splitter, cr.ui.Splitter, true);

	51 splitter.resizeNextElement = true;

	52 var nextElement = document.getElementById('next');

	53 nextElement.style.width = '0px';

	54 var beforeWidth = parseFloat(nextElement.style.width);

	55

	56 var down = new MouseEvent('mousedown',

	57 {button: 0, cancelable: true, clientX: 100});

	58 splitter.dispatchEvent(down);

	59

	60 var move = new MouseEvent('mousemove',

	61 {button: 0, cancelable: true, clientX: 50});

	62 splitter.dispatchEvent(move);
	Dan Beam 2016/03/07 18:14:19 why do we need this middle 'mousemove' as well? why do we need this middle 'mousemove' as well?
	63

	64 move = new MouseEvent('mousemove',

	65 {button: 0, cancelable: true, clientX: 0});

	66 splitter.dispatchEvent(move);

	67

	68 var up = new MouseEvent('mouseup',

	69 {button: 0, cancelable: true, clientX: 0});

	70 splitter.dispatchEvent(up);

	71

	72 var afterWidth = parseFloat(nextElement.style.width);

	73 assertEquals(100, afterWidth-beforeWidth);
	Dan Beam 2016/03/07 18:14:20 afterWidth - beforeWidth ^ ^ afterWidth - beforeWidth ^ ^ ryoh 2016/03/08 01:24:32 Done. Show quoted text On 2016/03/07 18:14:20, Dan Beam wrote: > afterWidth - beforeWidth > ^ ^ Done.
	74 }

20 </script>	75 </script>

21 </body>	76 </body>

22 </html>	77 </html>

OLD	NEW

« no previous file with comments | « no previous file | ui/webui/resources/js/cr/ui/splitter.js » ('j') | ui/webui/resources/js/cr/ui/splitter.js » ('J')