Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 176063002: Reland: Add some handle read/write helpers to mojo/common/test/test_utils.h (Closed)

Created:
6 years, 10 months ago by yzshen1
Modified:
6 years, 10 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reland: Add some handle read/write helpers to mojo/common/test/test_utils.h This helps to refactor raw_channel_posix_unittest to run on multiple platforms. TEST=mojo_common_unittests,mojo_system_unittests BUG=None TBR=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -70 lines) Patch
M mojo/common/test/multiprocess_test_base_unittest.cc View 3 chunks +10 lines, -50 lines 0 comments Download
A mojo/common/test/test_utils.h View 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/common/test/test_utils_posix.cc View 1 chunk +77 lines, -0 lines 0 comments Download
A mojo/common/test/test_utils_win.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/system/raw_channel_posix_unittest.cc View 6 chunks +8 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 10 months ago (2014-02-22 18:56:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/176063002/1
6 years, 10 months ago (2014-02-22 18:57:32 UTC) #2
commit-bot: I haz the power
Change committed as 252822
6 years, 10 months ago (2014-02-22 21:01:56 UTC) #3
viettrungluu
6 years, 10 months ago (2014-02-22 22:35:30 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698