Issue 176063002: Reland: Add some handle read/write helpers to mojo/common/test/test_utils.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176063002: Reland: Add some handle read/write helpers to mojo/common/test/test_utils.h (Closed)

Created:
6 years, 10 months ago by yzshen1

Modified:
6 years, 10 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Reland: Add some handle read/write helpers to mojo/common/test/test_utils.h This helps to refactor raw_channel_posix_unittest to run on multiple platforms. TEST=mojo_common_unittests,mojo_system_unittests BUG=None TBR=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252822

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+222 lines, -70 lines)			Patch
M	mojo/common/test/multiprocess_test_base_unittest.cc	View	3 chunks	+10 lines, -50 lines	0 comments	Download
A	mojo/common/test/test_utils.h	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	mojo/common/test/test_utils_posix.cc	View	1 chunk	+77 lines, -0 lines	0 comments	Download
A	mojo/common/test/test_utils_win.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/system/raw_channel_posix_unittest.cc	View	6 chunks	+8 lines, -20 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/176063002/1

6 years, 10 months ago (2014-02-22 18:57:32 UTC) #2

Message was sent while issue was closed.

lgtm