Reland: Add some handle read/write helpers to mojo/common/test/test_utils.h

mojo/common/test/multiprocess_test_base_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/common/test/multiprocess_test_base.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
+#include "mojo/common/test/test_utils.h"
 #include "mojo/system/embedder/scoped_platform_handle.h"
 
 #if defined(OS_POSIX)
 #include <fcntl.h>
-#include <unistd.h>
-
-#include "base/posix/eintr_wrapper.h"
 #endif
 
 #if defined(OS_WIN)
-#include <windows.h>
-
 #include "base/win/windows_version.h"
 #endif
 
 namespace mojo {
+namespace test {
 namespace {
 
 // Returns true and logs a warning on Windows prior to Vista.
 bool SkipTest() {
 #if defined(OS_WIN)
   if (base::win::GetVersion() < base::win::VERSION_VISTA) {
     LOG(WARNING) << "Test skipped: Vista or later needed.";
     return true;
   }
 #endif
 
   return false;
 }
 
 bool IsNonBlocking(const embedder::PlatformHandle& handle) {
 #if defined(OS_WIN)
   // Haven't figured out a way to query whether a HANDLE was created with
   // FILE_FLAG_OVERLAPPED.
   return true;
 #else
   return fcntl(handle.fd, F_GETFL) & O_NONBLOCK;
 #endif
 }
 
-// Note: On POSIX, this method sets the handle to block.
 bool WriteByte(const embedder::PlatformHandle& handle, char c) {
-#if defined(OS_WIN)
-  DWORD num_bytes_written = 0;
-  OVERLAPPED overlapped = { 0 };
-
-  if (!WriteFile(handle.handle, &c, 1, &num_bytes_written, &overlapped)) {
-    if (GetLastError() != ERROR_IO_PENDING)
-      return false;
-
-    if (GetOverlappedResult(handle.handle, &overlapped, &num_bytes_written,
-                            TRUE)) {
-      return num_bytes_written == 1;
-    }
-
-    return false;
-  }
-  return num_bytes_written == 1;
-#else
-  // We're lazy. Set it to block.
-  PCHECK(fcntl(handle.fd, F_SETFL, 0) == 0);
-
-  return HANDLE_EINTR(write(handle.fd, &c, 1)) == 1;
-#endif
+  size_t bytes_written = 0;
+  BlockingWrite(handle, &c, 1, &bytes_written);
+  return bytes_written == 1;
 }
 
-// Note: On POSIX, this method sets the handle to block.
 bool ReadByte(const embedder::PlatformHandle& handle, char* c) {
-#if defined(OS_WIN)
-  DWORD num_bytes_read = 0;
-  OVERLAPPED overlapped = { 0 };
-
-  if (!ReadFile(handle.handle, c, 1, &num_bytes_read, &overlapped)) {
-    if (GetLastError() != ERROR_IO_PENDING)
-      return false;
-
-    if (GetOverlappedResult(handle.handle, &overlapped, &num_bytes_read, TRUE))
-      return num_bytes_read == 1;
-
-    return false;
-  }
-  return num_bytes_read == 1;
-#else
-  // We're lazy. Set it to block.
-  PCHECK(fcntl(handle.fd, F_SETFL, 0) == 0);
-
-  return HANDLE_EINTR(read(handle.fd, c, 1)) == 1;
-#endif
+  size_t bytes_read = 0;
+  BlockingRead(handle, c, 1, &bytes_read);
+  return bytes_read == 1;
 }
 
-typedef test::MultiprocessTestBase MultiprocessTestBaseTest;
+typedef MultiprocessTestBase MultiprocessTestBaseTest;
 
 TEST_F(MultiprocessTestBaseTest, RunChild) {
   if (SkipTest())
     return;
 
   EXPECT_TRUE(server_platform_handle.is_valid());
 
   StartChild("RunChild");
   EXPECT_EQ(123, WaitForChildShutdown());
 }
@@ skipping 55 matching lines @@
   // Write it back, incremented.
   c++;
   EXPECT_TRUE(WriteByte(handle.get(), c));
 
   // And return it, incremented again.
   c++;
   return static_cast<int>(c);
 }
 
 }  // namespace
+}  // namespace test
 }  // namespace mojo