Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 1760343003: Revert of Don't allow nullptr in texels array params (unless using a transfer buffer). (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@usesdk
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Don't allow nullptr in texels array params (unless using a transfer buffer). (patchset #3 id:60001 of https://codereview.chromium.org/1765633002/ ) Reason for revert: breaks vk build Original issue's description: > Don't allow nullptr in texels array params (unless using a transfer buffer). > > Require all levels in writePixels to have a non-nullptr. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765633002 > > Committed: https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec TBR=jvanverth@google.com,cblume@google.com,cblume@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d3312595c86289113ea5994234844388523499e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -99 lines) Patch
M include/gpu/GrTextureProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +16 lines, -7 lines 0 comments Download
M src/gpu/GrGpu.cpp View 5 chunks +21 lines, -11 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 4 chunks +9 lines, -22 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 16 chunks +53 lines, -56 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Don't allow nullptr in texels array params (unless using a transfer buffer).
4 years, 9 months ago (2016-03-04 15:06:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760343003/1
4 years, 9 months ago (2016-03-04 15:06:38 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:06:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d3312595c86289113ea5994234844388523499e8

Powered by Google App Engine
This is Rietveld 408576698