Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1760323002: [turbofan] SSA Validation (Closed)

Created:
4 years, 9 months ago by Mircea Trofin
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Validate that instruction selection maintains SSA form. It benefits certain algorithms in register allocation to assume the input is SSA - understanding that ResolvePhis in the regalloc pipeline lowers phis, thus blurring the SSA invariant. BUG= Committed: https://crrev.com/a59605efdae202c25e8328c6e5bedd7b6905f7e9 Cr-Commit-Position: refs/heads/master@{#34509}

Patch Set 1 #

Patch Set 2 : patch for add w overflow #

Patch Set 3 : one more fix - 64 bit add #

Patch Set 4 : just ssa validation, after other fixed made it in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M src/compiler/instruction.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/instruction.cc View 3 chunks +17 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Mircea Trofin
Note that the change is just patch 1, the other 2 are the add with ...
4 years, 9 months ago (2016-03-04 02:45:41 UTC) #3
Mircea Trofin
4 years, 9 months ago (2016-03-04 19:35:04 UTC) #5
titzer
lgtm
4 years, 9 months ago (2016-03-04 19:46:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760323002/60001
4 years, 9 months ago (2016-03-04 20:05:28 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-04 20:32:39 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 20:34:15 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a59605efdae202c25e8328c6e5bedd7b6905f7e9
Cr-Commit-Position: refs/heads/master@{#34509}

Powered by Google App Engine
This is Rietveld 408576698