Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1760313003: Make GuestModeOptionsUIBrowserTest inherit from OptionsBrowsertestBase (Closed)

Created:
4 years, 9 months ago by michaelpg
Modified:
4 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GuestModeOptionsUIBrowserTest inherit from OptionsBrowsertestBase BUG=591154 Committed: https://crrev.com/720dc6e7fb801f659cf0d14913d91b6aea739a7f Cr-Commit-Position: refs/heads/master@{#379204}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js View 1 3 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
michaelpg
4 years, 9 months ago (2016-03-04 01:37:16 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1760313003/diff/1/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js File chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js (right): https://codereview.chromium.org/1760313003/diff/1/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js#newcode43 chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js:43: /** * Test sections that should be hidden ...
4 years, 9 months ago (2016-03-04 02:50:02 UTC) #3
michaelpg
https://codereview.chromium.org/1760313003/diff/1/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js File chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js (right): https://codereview.chromium.org/1760313003/diff/1/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js#newcode43 chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js:43: /** * Test sections that should be hidden in ...
4 years, 9 months ago (2016-03-04 03:32:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760313003/20001
4 years, 9 months ago (2016-03-04 03:33:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 04:12:25 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 04:14:35 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/720dc6e7fb801f659cf0d14913d91b6aea739a7f
Cr-Commit-Position: refs/heads/master@{#379204}

Powered by Google App Engine
This is Rietveld 408576698