Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4150)

Unified Diff: chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js

Issue 1760313003: Make GuestModeOptionsUIBrowserTest inherit from OptionsBrowsertestBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js b/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js
index 193e970ce563c32e531083421937aba1d28f0a65..b7a52858ed81cc7564fe999e85f50033b1d4e6b8 100644
--- a/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js
+++ b/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js
@@ -2,18 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+GEN_INCLUDE(['../options_browsertest_base.js']);
GEN('#include "chrome/browser/ui/webui/options/chromeos/' +
'guest_mode_options_browsertest.h"');
/**
* TestFixture for guest mode options WebUI testing.
- * @extends {testing.Test}
+ * @extends {OptionsBrowsertestBase}
* @constructor
*/
function GuestModeOptionsUIBrowserTest() {}
GuestModeOptionsUIBrowserTest.prototype = {
- __proto__: testing.Test.prototype,
+ __proto__: OptionsBrowsertestBase.prototype,
/** @override */
browsePreload: 'chrome://settings-frame',
@@ -39,11 +40,8 @@ GuestModeOptionsUIBrowserTest.prototype = {
},
};
-/**
- * Test sections that should be hidden in guest mode.
- * TODO(michaelpg): Debug flakiness: crbug.com/591154.
- */
-TEST_F('GuestModeOptionsUIBrowserTest', 'DISABLED_testSections', function() {
+/** Test sections that should be hidden in guest mode. */
+TEST_F('GuestModeOptionsUIBrowserTest', 'testSections', function() {
this.expectHidden($('startup-section'));
this.expectHidden($('appearance-section'));
this.expectHidden($('andorid-apps-section'));
@@ -52,11 +50,8 @@ TEST_F('GuestModeOptionsUIBrowserTest', 'DISABLED_testSections', function() {
this.expectHidden($('reset-profile-settings-section'));
});
-/**
- * Test controls that should be disabled in guest mode.
- * TODO(michaelpg): Debug flakiness: crbug.com/591154.
- */
-TEST_F('GuestModeOptionsUIBrowserTest', 'DISABLED_testControls', function() {
+/** Test controls that should be disabled in guest mode. */
+TEST_F('GuestModeOptionsUIBrowserTest', 'testControls', function() {
// Appearance section.
var setWallpaper = $('set-wallpaper');
expectTrue(setWallpaper.disabled);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698