third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html - Issue 1760183002: Fixed missing pointerTypes for touch events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

Issue 1760183002: Fixed missing pointerTypes for touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaked existing layouttests for some converage. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/converters/blink/blink_input_events_type_converters.cc ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-event-properties.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html b/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

index f79c6dbeecfbdce82961c1971adcb9a91b3690cc..f26865571da2a03cdaffc67032112103f3bd0e3e 100644

--- a/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

+++ b/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

@@ -69,8 +69,7 @@ function init() {

}

shouldBeEqualToNumber("lastPointerEvent.pointerId", 1);

- // TODO(crbug.com/557817): linux_chromium_rel_ng fails here, sets to empty string.

Rick Byers 2016/03/08 15:43:37 excellent!

- // shouldBeEqualToString("lastPointerEvent.pointerType", "mouse");

+ shouldBeEqualToString("lastPointerEvent.pointerType", "mouse");

shouldBeTrue("lastPointerEvent.isPrimary");

numericAttributes.forEach(function(attribute) {