third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html - Issue 1760183002: Fixed missing pointerTypes for touch events.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

Issue 1760183002: Fixed missing pointerTypes for touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaked existing layouttests for some converage. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « mojo/converters/blink/blink_input_events_type_converters.cc ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-event-properties.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <script src="../resources/input-modifiers.js"></script>	3 <script src="../resources/input-modifiers.js"></script>

4 <style>	4 <style>

5 div.box {	5 div.box {

6 margin: 10px;	6 margin: 10px;

7 padding: 50px;	7 padding: 50px;

8 float: left;	8 float: left;

9 }	9 }

10 </style>	10 </style>

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62	62

63 if (lastPointerEvent.type=="pointerenter" \|\| lastPointerEvent.type=="p ointerleave") {	63 if (lastPointerEvent.type=="pointerenter" \|\| lastPointerEvent.type=="p ointerleave") {

64 shouldBeFalse("lastPointerEvent.bubbles");	64 shouldBeFalse("lastPointerEvent.bubbles");

65 shouldBeFalse("lastPointerEvent.cancelable");	65 shouldBeFalse("lastPointerEvent.cancelable");

66 } else {	66 } else {

67 shouldBeTrue("lastPointerEvent.bubbles");	67 shouldBeTrue("lastPointerEvent.bubbles");

68 shouldBeTrue("lastPointerEvent.cancelable");	68 shouldBeTrue("lastPointerEvent.cancelable");

69 }	69 }

70	70

71 shouldBeEqualToNumber("lastPointerEvent.pointerId", 1);	71 shouldBeEqualToNumber("lastPointerEvent.pointerId", 1);

72 // TODO(crbug.com/557817): linux_chromium_rel_ng fails here, sets to e mpty string.	72 shouldBeEqualToString("lastPointerEvent.pointerType", "mouse");
Rick Byers 2016/03/08 15:43:37 excellent! excellent!
73 // shouldBeEqualToString("lastPointerEvent.pointerType", "mouse");

74 shouldBeTrue("lastPointerEvent.isPrimary");	73 shouldBeTrue("lastPointerEvent.isPrimary");

75	74

76 numericAttributes.forEach(function(attribute) {	75 numericAttributes.forEach(function(attribute) {

77 var expectedValue = eval("event." + attribute);	76 var expectedValue = eval("event." + attribute);

78 if (attribute == "button" && event.type != "mousedown" && event.type != "mouseup")	77 if (attribute == "button" && event.type != "mousedown" && event.type != "mouseup")

79 expectedValue = -1;	78 expectedValue = -1;

80 if (attribute == "pressure") {	79 if (attribute == "pressure") {

81 if (event.buttons == 0)	80 if (event.buttons == 0)

82 expectedValue = 0.0;	81 expectedValue = 0.0;

83 else	82 else

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
138 eventSender.mouseMoveTo(rect.left - 5, rect.top - 5);	137 eventSender.mouseMoveTo(rect.left - 5, rect.top - 5);

139 }	138 }

140	139

141 init();	140 init();

142 if (window.eventSender)	141 if (window.eventSender)

143 runTests();	142 runTests();

144 else	143 else

145 debug("This test requires eventSender");	144 debug("This test requires eventSender");

146	145

147 </script>	146 </script>

OLD	NEW