Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: git_cl.py

Issue 1760063002: git cl: stop downloading Gerrit commit-hook with --squash mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@G0850
Patch Set: fix tests, for real this time. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 1666f33dc916c848537e7aa22911f27b131a660c..d236e8596a8cf832819d6ae39f65d0904b116d4b 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -600,10 +600,6 @@ class Settings(object):
cr_settings_file = FindCodereviewSettingsFile()
if autoupdate != 'false' and cr_settings_file:
LoadCodereviewSettingsFromFile(cr_settings_file)
- # set updated to True to avoid infinite calling loop
- # through DownloadGerritHook
- self.updated = True
- DownloadGerritHook(False)
self.updated = True
def GetDefaultServerUrl(self, error_ok=False):
@@ -2244,6 +2240,7 @@ def GerritUpload(options, args, cl, change):
'-m', message]).strip()
else:
if not git_footers.get_footer_change_id(change_desc.description):
+ DownloadGerritHook(False)
AddChangeIdToCommitMessage(options, args)
ref_to_push = 'HEAD'
parent = '%s/%s' % (gerrit_remote, branch)
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698