Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tests/co19/co19-runtime.status

Issue 1760043002: Skip mirror tests more generally for $mode == product instead of $runtime == dart_product. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/co19/co19-runtime.status
diff --git a/tests/co19/co19-runtime.status b/tests/co19/co19-runtime.status
index 89465540d86add38b067e791ac05551865a3f007..122b3a545ef33e710ed2aad1532c798a4291105f 100644
--- a/tests/co19/co19-runtime.status
+++ b/tests/co19/co19-runtime.status
@@ -142,21 +142,19 @@ Language/Errors_and_Warnings/static_warning_t04: RuntimeError # co19 issue 45
Language/Errors_and_Warnings/static_warning_t05: RuntimeError # co19 issue 45
Language/Errors_and_Warnings/static_warning_t06: RuntimeError # co19 issue 45
-[ $noopt || $compiler == precompiler ]
+[ $noopt || $compiler == precompiler || $mode == product ]
Language/Metadata/*: SkipByDesign # Uses dart:mirrors
-LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout
-LibTest/collection/ListMixin/ListMixin_class_A01_t02: Pass, Timeout
-LibTest/core/Map/Map_class_A01_t04: Pass, Timeout
-LibTest/core/Uri/encodeQueryComponent_A01_t02: Pass, Timeout
-[ $runtime == dart_precompiled ]
-LibTest/isolate/Isolate/spawnUri*: RuntimeError # Isolate.spawnUri
+[ $runtime == dart_precompiled || $runtime == dart_product ]
+LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
Language/Expressions/Constants/identifier_denotes_a_constant_t05: Crash # Issue 25892
Language/Expressions/Constants/static_method_t01: Crash # Issue 25892
siva 2016/03/03 17:31:16 The crashes need to be dart_precompiled only.
rmacnak 2016/03/03 18:04:52 Fixed.
-[ $runtime == dart_product ]
-LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
-Language/Metadata/*: SkipByDesign # Uses dart:mirrors
+[ $noopt || $compiler == precompiler ]
+LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout
+LibTest/collection/ListMixin/ListMixin_class_A01_t02: Pass, Timeout
+LibTest/core/Map/Map_class_A01_t04: Pass, Timeout
+LibTest/core/Uri/encodeQueryComponent_A01_t02: Pass, Timeout
[ $runtime == vm && $mode == product ]
LibTest/typed_data/Float32List/runtimeType_A01_t01: Fail,OK # Expects exact type name.
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698