src/objects.h - Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: comments addressed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index a758ff37d78bfa1f801e56126edfdf1999063c0e..2e2a01845b7661696bc4fb841701891526d5d4eb 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -5752,7 +5752,7 @@ class Script: public Struct {

DECL_ACCESSORS(name, Object)

// [id]: the script id.

- DECL_ACCESSORS(id, Object)

+ DECL_ACCESSORS(id, Smi)

// [line_offset]: script line offset in resource from where it was extracted.

DECL_ACCESSORS(line_offset, Smi)

« no previous file with comments | « src/heap-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »