Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: include/v8.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index de3a40ff3388e2bd2dcbf50c15b36123c2d16286..c7ec411ecf19b0e90414d99d32a7af2efe23d4e7 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1044,7 +1044,12 @@ class V8EXPORT Script {
/**
* Returns the script id value.
*/
- Local<Value> Id();
+ V8_DEPRECATED(Local<Value> Id());
yurys 2013/06/25 11:57:38 Won't this break Blink compilation?
loislo 2013/06/25 13:04:53 Done.
+
+ /**
+ * Returns the script id value.
+ */
+ int GetId();
/**
* Associate an additional data object with the script. This is mainly used
@@ -2347,7 +2352,10 @@ class V8EXPORT Function : public Object {
* kLineOffsetNotFound if no information available.
*/
int GetScriptColumnNumber() const;
- Handle<Value> GetScriptId() const;
+
+ V8_DEPRECATED(Handle<Value> GetScriptId() const);
+
+ int ScriptId() const;
yurys 2013/06/25 11:57:38 Same question.
loislo 2013/06/25 13:04:53 Done.
ScriptOrigin GetScriptOrigin() const;
V8_INLINE(static Function* Cast(Value* obj));
static const int kLineOffsetNotFound;
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698