Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: include/v8.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 * context independent (created using ::New) it will be run in the 1037 * context independent (created using ::New) it will be run in the
1038 * currently entered context. If it is context specific (created 1038 * currently entered context. If it is context specific (created
1039 * using ::Compile) it will be run in the context in which it was 1039 * using ::Compile) it will be run in the context in which it was
1040 * compiled. 1040 * compiled.
1041 */ 1041 */
1042 Local<Value> Run(); 1042 Local<Value> Run();
1043 1043
1044 /** 1044 /**
1045 * Returns the script id value. 1045 * Returns the script id value.
1046 */ 1046 */
1047 Local<Value> Id(); 1047 V8_DEPRECATED(Local<Value> Id());
yurys 2013/06/25 11:57:38 Won't this break Blink compilation?
loislo 2013/06/25 13:04:53 Done.
1048
1049 /**
1050 * Returns the script id value.
1051 */
1052 int GetId();
1048 1053
1049 /** 1054 /**
1050 * Associate an additional data object with the script. This is mainly used 1055 * Associate an additional data object with the script. This is mainly used
1051 * with the debugger as this data object is only available through the 1056 * with the debugger as this data object is only available through the
1052 * debugger API. 1057 * debugger API.
1053 */ 1058 */
1054 void SetData(Handle<String> data); 1059 void SetData(Handle<String> data);
1055 1060
1056 /** 1061 /**
1057 * Returns the name value of one Script. 1062 * Returns the name value of one Script.
(...skipping 1282 matching lines...) Expand 10 before | Expand all | Expand 10 after
2340 /** 2345 /**
2341 * Returns zero based line number of function body and 2346 * Returns zero based line number of function body and
2342 * kLineOffsetNotFound if no information available. 2347 * kLineOffsetNotFound if no information available.
2343 */ 2348 */
2344 int GetScriptLineNumber() const; 2349 int GetScriptLineNumber() const;
2345 /** 2350 /**
2346 * Returns zero based column number of function body and 2351 * Returns zero based column number of function body and
2347 * kLineOffsetNotFound if no information available. 2352 * kLineOffsetNotFound if no information available.
2348 */ 2353 */
2349 int GetScriptColumnNumber() const; 2354 int GetScriptColumnNumber() const;
2350 Handle<Value> GetScriptId() const; 2355
2356 V8_DEPRECATED(Handle<Value> GetScriptId() const);
2357
2358 int ScriptId() const;
yurys 2013/06/25 11:57:38 Same question.
loislo 2013/06/25 13:04:53 Done.
2351 ScriptOrigin GetScriptOrigin() const; 2359 ScriptOrigin GetScriptOrigin() const;
2352 V8_INLINE(static Function* Cast(Value* obj)); 2360 V8_INLINE(static Function* Cast(Value* obj));
2353 static const int kLineOffsetNotFound; 2361 static const int kLineOffsetNotFound;
2354 2362
2355 private: 2363 private:
2356 Function(); 2364 Function();
2357 static void CheckCast(Value* obj); 2365 static void CheckCast(Value* obj);
2358 }; 2366 };
2359 2367
2360 #ifndef V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT 2368 #ifndef V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT
(...skipping 4073 matching lines...) Expand 10 before | Expand all | Expand 10 after
6434 6442
6435 6443
6436 } // namespace v8 6444 } // namespace v8
6437 6445
6438 6446
6439 #undef V8EXPORT 6447 #undef V8EXPORT
6440 #undef TYPE_CHECK 6448 #undef TYPE_CHECK
6441 6449
6442 6450
6443 #endif // V8_H_ 6451 #endif // V8_H_
OLDNEW
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698