CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1026 matching lines @@
    * context independent (created using ::New) it will be run in the
    * currently entered context.  If it is context specific (created
    * using ::Compile) it will be run in the context in which it was
    * compiled.
    */
   Local<Value> Run();
 
   /**
    * Returns the script id value.
    */
-  Local<Value> Id();
+  V8_DEPRECATED(Local<Value> Id());

[yurys, 2013/06/25 11:57:38]

Won't this break Blink compilation?

[loislo, 2013/06/25 13:04:53]

Done.

+
+  /**
+   * Returns the script id value.
+   */
+  int GetId();
 
   /**
    * Associate an additional data object with the script. This is mainly used
    * with the debugger as this data object is only available through the
    * debugger API.
    */
   void SetData(Handle<String> data);
 
   /**
    * Returns the name value of one Script.
@@ skipping 1282 matching lines @@
   /**
    * Returns zero based line number of function body and
    * kLineOffsetNotFound if no information available.
    */
   int GetScriptLineNumber() const;
   /**
    * Returns zero based column number of function body and
    * kLineOffsetNotFound if no information available.
    */
   int GetScriptColumnNumber() const;
-  Handle<Value> GetScriptId() const;
+
+  V8_DEPRECATED(Handle<Value> GetScriptId() const);
+
+  int ScriptId() const;

[yurys, 2013/06/25 11:57:38]

Same question.

[loislo, 2013/06/25 13:04:53]

Done.

   ScriptOrigin GetScriptOrigin() const;
   V8_INLINE(static Function* Cast(Value* obj));
   static const int kLineOffsetNotFound;
 
  private:
   Function();
   static void CheckCast(Value* obj);
 };
 
 #ifndef V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT
@@ skipping 4073 matching lines @@
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_