CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index de3a40ff3388e2bd2dcbf50c15b36123c2d16286..c7ec411ecf19b0e90414d99d32a7af2efe23d4e7 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1044,7 +1044,12 @@ class V8EXPORT Script {
   /**
    * Returns the script id value.
    */
-  Local<Value> Id();
+  V8_DEPRECATED(Local<Value> Id());

[yurys, 2013/06/25 11:57:38]

Won't this break Blink compilation?

[loislo, 2013/06/25 13:04:53]

Done.

+
+  /**
+   * Returns the script id value.
+   */
+  int GetId();
 
   /**
    * Associate an additional data object with the script. This is mainly used
@@ -2347,7 +2352,10 @@ class V8EXPORT Function : public Object {
    * kLineOffsetNotFound if no information available.
    */
   int GetScriptColumnNumber() const;
-  Handle<Value> GetScriptId() const;
+
+  V8_DEPRECATED(Handle<Value> GetScriptId() const);
+
+  int ScriptId() const;

[yurys, 2013/06/25 11:57:38]

Same question.

[loislo, 2013/06/25 13:04:53]

Done.

   ScriptOrigin GetScriptOrigin() const;
   V8_INLINE(static Function* Cast(Value* obj));
   static const int kLineOffsetNotFound;