[libphonenumber] Run tests on swarming

[libphonenumber] Run tests on swarming

Also adding some files and their tests.

BUG=585151
Committed: https://crrev.com/85d385a2ec9f6d365fee5a14fd2a5ea564ffb1a7
Cr-Commit-Position: refs/heads/master@{#382114}

[Mathieu, 2016-03-15 21:08:03]

mathp@chromium.org changed reviewers:
+ thakis@chromium.org

[Mathieu, 2016-03-15 21:08:04]

Hi Nico, 

This is ready for review. Thanks!

[Mathieu, 2016-03-15 21:08:23]

Description was changed from

==========
[libphonenumber] Run tests on swarming

BUG=585151
==========

to

==========
[libphonenumber] Run tests on swarming

Also adding some files and their tests.

BUG=585151
==========

[Nico, 2016-03-17 16:23:14]

thanks! Just one comment:

https://codereview.chromium.org/1759723002/diff/60001/testing/buildbot/chromi...
File testing/buildbot/chromium.memory.fyi.json (left):

https://codereview.chromium.org/1759723002/diff/60001/testing/buildbot/chromi...
testing/buildbot/chromium.memory.fyi.json:274: "libphonenumber_unittests",
why remove it from this file? then it won't run on the memory bots

https://codereview.chromium.org/1759723002/diff/60001/third_party/libphonenum...
File third_party/libphonenumber/libphonenumber_unittests.isolate (right):

https://codereview.chromium.org/1759723002/diff/60001/third_party/libphonenum...
third_party/libphonenumber/libphonenumber_unittests.isolate:12:
'dist/resources/test/',
Since you need this, do you need a `data = ...` in libhphonenumber's BUILD.gn
too? (gn doesn't use .isolate files but data statements in .gn files for the
same thing instead)

Example:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/BUILD.gn&...

[Mathieu, 2016-03-18 13:19:16]

Thanks. PTAL

https://codereview.chromium.org/1759723002/diff/60001/testing/buildbot/chromi...
File testing/buildbot/chromium.memory.fyi.json (left):

https://codereview.chromium.org/1759723002/diff/60001/testing/buildbot/chromi...
testing/buildbot/chromium.memory.fyi.json:274: "libphonenumber_unittests",
On 2016/03/17 at 16:23:14, Nico (afk Mon-Tue Mar 14-15) wrote:
> why remove it from this file? then it won't run on the memory bots

Sure. I misunderstood the bug.

https://codereview.chromium.org/1759723002/diff/60001/third_party/libphonenum...
File third_party/libphonenumber/libphonenumber_unittests.isolate (right):

https://codereview.chromium.org/1759723002/diff/60001/third_party/libphonenum...
third_party/libphonenumber/libphonenumber_unittests.isolate:12:
'dist/resources/test/',
On 2016/03/17 at 16:23:14, Nico (afk Mon-Tue Mar 14-15) wrote:
> Since you need this, do you need a `data = ...` in libhphonenumber's BUILD.gn
too? (gn doesn't use .isolate files but data statements in .gn files for the
same thing instead)
> 
> Example:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/BUILD.gn&...

fair point! Done.

[Nico, 2016-03-18 22:32:25]

lgtm

[Nico, 2016-03-18 22:32:30]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-03-18 22:32:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1759723002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1759723002/80001

[commit-bot: I haz the power, 2016-03-18 22:43:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-18 22:45:43]

Description was changed from

==========
[libphonenumber] Run tests on swarming

Also adding some files and their tests.

BUG=585151
==========

to

==========
[libphonenumber] Run tests on swarming

Also adding some files and their tests.

BUG=585151

Committed: https://crrev.com/85d385a2ec9f6d365fee5a14fd2a5ea564ffb1a7
Cr-Commit-Position: refs/heads/master@{#382114}
==========

[commit-bot: I haz the power, 2016-03-18 22:45:44]

Patchset 5 (id:??) landed as
https://crrev.com/85d385a2ec9f6d365fee5a14fd2a5ea564ffb1a7
Cr-Commit-Position: refs/heads/master@{#382114}

[phoglund_chromium, 2016-03-21 14:33:20]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1817083002/ by phoglund@chromium.org.

The reason for reverting is:
PhoneNumberMatcherTest.MatchesWithStrictGroupingLeniency fails on Win 7:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....

[Mathieu, 2016-03-27 20:02:55]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[Mathieu, 2016-03-27 20:02:56]

+rouslan

Blast! The whole test suite seems to time out on Windows 7 and this particular
bot.

Here's the output. Does anyone have an idea why or how to mitigate this?

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

[Mathieu, 2016-03-27 20:04:11]

I see some tests taking a whole 27s to run, which should definitely not be the
case. Could there be resource contention...?