third_party/libphonenumber/libphonenumber_unittests.isolate - Issue 1759723002: [libphonenumber] Run tests on swarming

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libphonenumber/libphonenumber_unittests.isolate

Issue 1759723002: [libphonenumber] Run tests on swarming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix included files Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« testing/buildbot/chromium.memory.fyi.json ('K') | « third_party/libphonenumber/libphonenumber.gyp ('k') | tools/valgrind/gtest_exclude/libphonenumber_unittests.gtest-drmemory_win32.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'conditions': [	5 'conditions': [

6 ['OS=="linux" or OS=="mac" or OS=="win"', {	6 ['OS=="linux" or OS=="mac" or OS=="win"', {

7 'variables': {	7 'variables': {

8 'command': [	8 'command': [

9 '<(PRODUCT_DIR)/gn_unittests<(EXECUTABLE_SUFFIX)',	9 '<(PRODUCT_DIR)/libphonenumber_unittests<(EXECUTABLE_SUFFIX)',

10 ],	10 ],

11 'files': [	11 'files': [

12 'format_test_data/',	12 'dist/resources/test/',
	Nico 2016/03/17 16:23:14 Since you need this, do you need a `data = ...` in Since you need this, do you need a `data = ...` in libhphonenumber's BUILD.gn too? (gn doesn't use .isolate files but data statements in .gn files for the same thing instead) Example: https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/BUILD.gn&... Mathieu 2016/03/18 13:19:16 fair point! Done. Show quoted text On 2016/03/17 at 16:23:14, Nico (afk Mon-Tue Mar 14-15) wrote: > Since you need this, do you need a `data = ...` in libhphonenumber's BUILD.gn too? (gn doesn't use .isolate files but data statements in .gn files for the same thing instead) > > Example: https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/BUILD.gn&... fair point! Done.
13 ],	13 ],

14 },	14 },

15 }],	15 }],

16 ],	16 ],

17 'includes': [	17 'includes': [

18 '../../base/base.isolate',	18 '../../base/base.isolate',

19 ],	19 ],

20 }	20 }

OLD	NEW