chrome/browser/ui/views/translate/translate_icon_view.cc - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_icon_view.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/translate/translate_icon_view.cc

diff --git a/chrome/browser/ui/views/translate/translate_icon_view.cc b/chrome/browser/ui/views/translate/translate_icon_view.cc

index b4061543966466ebe12654de8e97b1c5593bcb85..1b1d24cabab6e50fc8058d8ad4f476ef1e977dc0 100644

--- a/chrome/browser/ui/views/translate/translate_icon_view.cc

+++ b/chrome/browser/ui/views/translate/translate_icon_view.cc

@@ -26,7 +26,7 @@ TranslateIconView::~TranslateIconView() {}

void TranslateIconView::OnExecuting(

BubbleIconView::ExecuteSource execute_source) {}

-views::BubbleDelegateView* TranslateIconView::GetBubble() const {

+views::BubbleDialogDelegateView* TranslateIconView::GetBubble() const {

return TranslateBubbleView::GetCurrentBubble();

}

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/translate/translate_icon_view.h ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »