chrome/chrome_browser_ui.gypi - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/translate/translate_icon_view.cc ('k') | ui/views/bubble/bubble_dialog_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index e1dbbb34e7f4cc98a8d4021bda5a701545fed3f3..e931fe5a6dd3d30705e8086cdaeaf9d8864b1f47 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -2124,6 +2124,8 @@

'browser/ui/views/extensions/extension_keybinding_registry_views.h',

'browser/ui/views/frame/native_widget_mac_frameless_nswindow.h',

'browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm',

+ 'browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc',

+ 'browser/ui/views/location_bar/location_bar_bubble_delegate_view.h',

'browser/ui/views/login_prompt_views.cc',

'browser/ui/views/login_view.cc',

'browser/ui/views/login_view.h',

@@ -2353,8 +2355,6 @@

'browser/ui/views/location_bar/icon_label_bubble_view.h',

'browser/ui/views/location_bar/keyword_hint_view.cc',

'browser/ui/views/location_bar/keyword_hint_view.h',

- 'browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc',

- 'browser/ui/views/location_bar/location_bar_bubble_delegate_view.h',

'browser/ui/views/location_bar/location_bar_decoration_view.cc',

'browser/ui/views/location_bar/location_bar_decoration_view.h',

'browser/ui/views/location_bar/location_bar_layout.cc',