Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
index 56e6d94d516e9a2c81726774045c7925e3867d8a..230b82dbdd9b913f62d14367a42308508fd02510 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
@@ -27,7 +27,7 @@ void ManagePasswordsIconViews::SetState(password_manager::ui::State state) {
if (state_ == state)
return;
// If there is an opened bubble for the current icon it should go away.
- ManagePasswordsBubbleView::CloseBubble();
+ ManagePasswordsBubbleView::CloseCurrentBubble();
state_ = state;
UpdateUiForState();
}
@@ -56,7 +56,7 @@ void ManagePasswordsIconViews::OnExecuting(
bool ManagePasswordsIconViews::OnMousePressed(const ui::MouseEvent& event) {
bool result = BubbleIconView::OnMousePressed(event);
- ManagePasswordsBubbleView::CloseBubble();
+ ManagePasswordsBubbleView::CloseCurrentBubble();
return result;
}
@@ -74,7 +74,7 @@ bool ManagePasswordsIconViews::OnKeyPressed(const ui::KeyEvent& event) {
return BubbleIconView::OnKeyPressed(event);
}
-views::BubbleDelegateView* ManagePasswordsIconViews::GetBubble() const {
+views::BubbleDialogDelegateView* ManagePasswordsIconViews::GetBubble() const {
return ManagePasswordsBubbleView::manage_password_bubble();
}

Powered by Google App Engine
This is Rietveld 408576698