chrome/browser/ui/views/tab_dialogs_views.cc - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_dialogs_views.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tab_dialogs_views.cc

diff --git a/chrome/browser/ui/views/tab_dialogs_views.cc b/chrome/browser/ui/views/tab_dialogs_views.cc

index d829ee59b1e7ddd837556757e1eab9cbb0c2b885..ba73564668927d1f71578ba5e41a389e1f8af208 100644

--- a/chrome/browser/ui/views/tab_dialogs_views.cc

+++ b/chrome/browser/ui/views/tab_dialogs_views.cc

@@ -57,7 +57,7 @@ void TabDialogsViews::ShowManagePasswordsBubble(bool user_action) {

if (ManagePasswordsBubbleView::manage_password_bubble()) {

// The bubble is currently shown for some other tab. We should close it now

// and open for |web_contents_|.

- ManagePasswordsBubbleView::CloseBubble();

+ ManagePasswordsBubbleView::CloseCurrentBubble();

}

ManagePasswordsBubbleView::ShowBubble(

web_contents_, user_action ? ManagePasswordsBubbleView::USER_GESTURE

@@ -70,7 +70,7 @@ void TabDialogsViews::HideManagePasswordsBubble() {

content::WebContents* bubble_web_contents =

ManagePasswordsBubbleView::manage_password_bubble()->web_contents();

if (web_contents_ == bubble_web_contents)

- ManagePasswordsBubbleView::CloseBubble();

+ ManagePasswordsBubbleView::CloseCurrentBubble();

}

scoped_ptr<ValidationMessageBubble> TabDialogsViews::ShowValidationMessage(