chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/autofill/save_card_icon_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

index 580f4d15f8df6b92b24e6992381f198577e9d765..4bb93aca9330b0784bcbfe0d6cf10358f411a925 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

@@ -12,7 +12,7 @@

#include "base/strings/string16.h"

#include "chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h"

#include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h"

-#include "ui/views/bubble/bubble_delegate.h"

+#include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h"

#include "ui/views/controls/button/button.h"

#include "ui/views/controls/combobox/combobox_listener.h"

#include "url/gurl.h"

@@ -32,7 +32,7 @@ class Textfield;

// Bubble. BookmarkBubbleView provides views for unstarring and editing the

// bookmark it is created with. Don't create a BookmarkBubbleView directly,

// instead use the static Show method.

-class BookmarkBubbleView : public views::BubbleDelegateView,

+class BookmarkBubbleView : public LocationBarBubbleDelegateView,

public views::ButtonListener,

public views::ComboboxListener {

public: