Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1926)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index 81a488b7a3a753fd7410b2d468af7d5eab5564b4..c9e0292c21a0376aae8330a8c73ca0bfc92b37df 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -85,7 +85,7 @@ views::Widget* BookmarkBubbleView::ShowBubble(
bookmark_bubble_->set_parent_window(parent_window);
}
views::Widget* bubble_widget =
- views::BubbleDelegateView::CreateBubble(bookmark_bubble_);
+ views::BubbleDialogDelegateView::CreateBubble(bookmark_bubble_);
bubble_widget->Show();
// Select the entire title textfield contents when the bubble is first shown.
bookmark_bubble_->title_tf_->SelectAll(true);
@@ -148,7 +148,7 @@ bool BookmarkBubbleView::AcceleratorPressed(
apply_edits_ = false;
}
- return BubbleDelegateView::AcceleratorPressed(accelerator);
+ return LocationBarBubbleDelegateView::AcceleratorPressed(accelerator);
}
void BookmarkBubbleView::Init() {
@@ -222,6 +222,7 @@ void BookmarkBubbleView::Init() {
AddAccelerator(ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE));
AddAccelerator(ui::Accelerator(ui::VKEY_E, ui::EF_ALT_DOWN));
AddAccelerator(ui::Accelerator(ui::VKEY_R, ui::EF_ALT_DOWN));
+ AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
}
base::string16 BookmarkBubbleView::GetWindowTitle() const {
@@ -256,7 +257,7 @@ BookmarkBubbleView::BookmarkBubbleView(
Profile* profile,
const GURL& url,
bool newly_bookmarked)
- : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
+ : LocationBarBubbleDelegateView(anchor_view, nullptr),
observer_(observer),
delegate_(std::move(delegate)),
profile_(profile),
@@ -289,7 +290,7 @@ base::string16 BookmarkBubbleView::GetTitle() {
}
void BookmarkBubbleView::GetAccessibleState(ui::AXViewState* state) {
- BubbleDelegateView::GetAccessibleState(state);
+ LocationBarBubbleDelegateView::GetAccessibleState(state);
state->name =
l10n_util::GetStringUTF16(
newly_bookmarked_ ? IDS_BOOKMARK_BUBBLE_PAGE_BOOKMARKED :

Powered by Google App Engine
This is Rietveld 408576698